Merge pull request microsoft#182030 from microsoft/ulugbekna/fix-empty-command-id

fix: restore old behavior of not preventing default and not executing keybindings with empty command ID bound (microsoft#181920)

Author: sandy081

src/vs/platform/keybinding/common/abstractKeybindingService.ts

@@ -342,17 +342,16 @@ export abstract class AbstractKeybindingService extends Disposable implements IK
 
 				this._logService.trace('KeybindingService#dispatch', keypressLabel, `[ Will dispatch command ${resolveResult.commandId} ]`);
 
-				if (resolveResult.commandId === null) {
+				if (resolveResult.commandId === null || resolveResult.commandId === '') {
 
 					if (this.inChordMode) {
 						const currentChordsLabel = this._currentChords.map(({ label }) => label).join(', ');
 						this._log(`+ Leaving chord mode: Nothing bound to "${currentChordsLabel}, ${keypressLabel}".`);
 						this._notificationService.status(nls.localize('missing.chord', "The key combination ({0}, {1}) is not a command.", currentChordsLabel, keypressLabel), { hideAfter: 10 * 1000 /* 10s */ });
 						this._leaveChordMode();
+						shouldPreventDefault = true;
 					}
 
-					shouldPreventDefault = true;
-
 				} else {
 					if (this.inChordMode) {
 						this._leaveChordMode();