Add icon for deprecated messages in the settings ui (microsoft#135044)

Miguel Solorio · web-flow · commit 20e692d1d3b6 · 2021-10-13T16:43:38.000-07:00
diff --git a/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css b/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css
@@ -382,7 +382,11 @@
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message {
-	display: block;
+	display: flex;
+}
+
+.settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message .codicon {
+	margin-right: 4px;
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-description {
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts
@@ -868,6 +868,7 @@ export abstract class AbstractSettingRenderer extends Disposable implements ITre
 		} else {
 			template.deprecationWarningElement.innerText = deprecationText;
 		}
+		template.deprecationWarningElement.prepend($('.codicon.codicon-error'));
 		template.containerElement.classList.toggle('is-deprecated', !!deprecationText);
 
 		this.renderValue(element, <ISettingItemTemplate>template, onChange);

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,11 @@`
`382`	`382`	`}`
`383`	`383`
`384`	`384`	`.settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message {`
`385`		`- display: block;`
	`385`	`+ display: flex;`
	`386`	`+}`
	`387`	`+`
	`388`	`+.settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message .codicon {`
	`389`	`+ margin-right: 4px;`
`386`	`390`	`}`
`387`	`391`
`388`	`392`	`.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-description {`
Original file line number	Diff line number	Diff line change
`@@ -868,6 +868,7 @@ export abstract class AbstractSettingRenderer extends Disposable implements ITre`
`868`	`868`	`} else {`
`869`	`869`	`template.deprecationWarningElement.innerText = deprecationText;`
`870`	`870`	`}`
	`871`	`+ template.deprecationWarningElement.prepend($('.codicon.codicon-error'));`
`871`	`872`	`template.containerElement.classList.toggle('is-deprecated', !!deprecationText);`
`872`	`873`
`873`	`874`	`this.renderValue(element, <ISettingItemTemplate>template, onChange);`