Merge pull request microsoft#183040 from microsoft/merogge/run-selected

meganrogge · web-flow · commit 222a960b4487 · 2023-05-21T17:37:19.000-07:00
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalService.ts b/src/vs/workbench/contrib/terminal/browser/terminalService.ts
@@ -506,8 +506,7 @@ export class TerminalService implements ITerminalService {
 			return this.createTerminal();
 		}
 		// Active instance, ensure accepts input
-		// Don't use task terminals or other terminals that don't accept input
-		if (!options?.acceptsInput || activeInstance?.shellLaunchConfig.type !== 'Task' && activeInstance.xterm?.isStdinDisabled !== true) {
+		if (!options?.acceptsInput || activeInstance.xterm?.isStdinDisabled !== true) {
 			return activeInstance;
 		}
 		// Active instance doesn't accept input, create and focus

Original file line number	Diff line number	Diff line change
`@@ -506,8 +506,7 @@ export class TerminalService implements ITerminalService {`
`506`	`506`	`return this.createTerminal();`
`507`	`507`	`}`
`508`	`508`	`// Active instance, ensure accepts input`
`509`		`- // Don't use task terminals or other terminals that don't accept input`
`510`		`- if (!options?.acceptsInput \|\| activeInstance?.shellLaunchConfig.type !== 'Task' && activeInstance.xterm?.isStdinDisabled !== true) {`
	`509`	`+ if (!options?.acceptsInput \|\| activeInstance.xterm?.isStdinDisabled !== true) {`
`511`	`510`	`return activeInstance;`
`512`	`511`	`}`
`513`	`512`	`// Active instance doesn't accept input, create and focus`