Skip to content

Commit 22c1836

Browse files
author
aiday-mar
committed
Merge branch 'main' into aiday/stickyScrollTesting
2 parents b595675 + f8ad3a1 commit 22c1836

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

test/smoke/src/areas/workbench/data-loss.test.ts

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,18 @@ import { Application, ApplicationOptions, Logger, Quality } from '../../../../au
88
import { createApp, timeout, installDiagnosticsHandler, installAppAfterHandler, getRandomUserDataDir, suiteLogsPath, suiteCrashPath } from '../../utils';
99

1010
export function setup(ensureStableCode: () => string | undefined, logger: Logger) {
11-
describe('Data Loss (insiders -> insiders)', () => {
11+
describe('Data Loss (insiders -> insiders)', function () {
12+
13+
// There are cases where `exitApplication` does not actually
14+
// stop the application and our attempt then to `kill` the
15+
// process tree results in data loss / state loss. All these
16+
// tests here rely on state getting persisted properly, so
17+
// until we have figured out the root cause, we retry these
18+
// tests.
19+
// See: https://github.com/microsoft/vscode/issues/157979
20+
if (process.platform === 'darwin') {
21+
this.retries(2);
22+
}
1223

1324
let app: Application | undefined = undefined;
1425

@@ -130,7 +141,18 @@ export function setup(ensureStableCode: () => string | undefined, logger: Logger
130141
}
131142
});
132143

133-
describe('Data Loss (stable -> insiders)', () => {
144+
describe('Data Loss (stable -> insiders)', function () {
145+
146+
// There are cases where `exitApplication` does not actually
147+
// stop the application and our attempt then to `kill` the
148+
// process tree results in data loss / state loss. All these
149+
// tests here rely on state getting persisted properly, so
150+
// until we have figured out the root cause, we retry these
151+
// tests.
152+
// See: https://github.com/microsoft/vscode/issues/157979
153+
if (process.platform === 'darwin') {
154+
this.retries(2);
155+
}
134156

135157
let insidersApp: Application | undefined = undefined;
136158
let stableApp: Application | undefined = undefined;

0 commit comments

Comments
 (0)