Review usages of EditorOption.lineHeight (microsoft#248794) (microsoft#250625)

bpasero · web-flow · commit 2347ccb6428f · 2025-06-04T07:52:43.000-07:00
diff --git a/src/vs/workbench/contrib/codeEditor/browser/dictation/editorDictation.ts b/src/vs/workbench/contrib/codeEditor/browser/dictation/editorDictation.ts
@@ -152,7 +152,8 @@ export class DictationWidget extends Disposable implements IContentWidget {
 	}
 
 	beforeRender(): IDimension | null {
-		const lineHeight = this.editor.getOption(EditorOption.lineHeight);
+		const position = this.editor.getPosition();
+		const lineHeight = position ? this.editor.getLineHeightForPosition(position) : this.editor.getOption(EditorOption.lineHeight);
 		const width = this.editor.getLayoutInfo().contentWidth * 0.7;
 
 		this.domNode.style.setProperty('--vscode-editor-dictation-widget-height', `${lineHeight}px`);

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,8 @@ export class DictationWidget extends Disposable implements IContentWidget {`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`beforeRender(): IDimension \| null {`
`155`		`- const lineHeight = this.editor.getOption(EditorOption.lineHeight);`
	`155`	`+ const position = this.editor.getPosition();`
	`156`	`+ const lineHeight = position ? this.editor.getLineHeightForPosition(position) : this.editor.getOption(EditorOption.lineHeight);`
`156`	`157`	`const width = this.editor.getLayoutInfo().contentWidth * 0.7;`
`157`	`158`
`158`	`159`	this.domNode.style.setProperty('--vscode-editor-dictation-widget-height', `${lineHeight}px`);