dispose saved text model with wrong view type (microsoft#209461)

amunger · web-flow · commit 23860e98f0ef · 2024-04-03T11:40:33.000-07:00
diff --git a/src/vs/workbench/contrib/interactive/browser/interactiveEditorInput.ts b/src/vs/workbench/contrib/interactive/browser/interactiveEditorInput.ts
@@ -209,7 +209,11 @@ export class InteractiveEditorInput extends EditorInput implements ICompositeNot
 			return undefined; // save cancelled
 		}
 
-		return await this._editorModelReference.saveAs(target);
+		const saved = await this._editorModelReference.saveAs(target);
+		if (saved && 'resource' in saved && saved.resource) {
+			this._notebookService.getNotebookTextModel(saved.resource)?.dispose();
+		}
+		return saved;
 	}
 
 	override matches(otherInput: EditorInput | IUntypedEditorInput): boolean {

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,11 @@ export class InteractiveEditorInput extends EditorInput implements ICompositeNot`
`209`	`209`	`return undefined; // save cancelled`
`210`	`210`	`}`
`211`	`211`
`212`		`- return await this._editorModelReference.saveAs(target);`
	`212`	`+ const saved = await this._editorModelReference.saveAs(target);`
	`213`	`+ if (saved && 'resource' in saved && saved.resource) {`
	`214`	`+ this._notebookService.getNotebookTextModel(saved.resource)?.dispose();`
	`215`	`+ }`
	`216`	`+ return saved;`
`213`	`217`	`}`
`214`	`218`
`215`	`219`	`override matches(otherInput: EditorInput \| IUntypedEditorInput): boolean {`