Add cli override to control startupExp group (microsoft#253155)

* Add startup experiment group support to environment services

* refactor: streamline startup experiment group handling and remove unused code

* feat: add first session date check to initialize experiments

Author: bhavyaus

src/vs/platform/environment/common/argv.ts

@@ -138,6 +138,7 @@ export interface NativeParsedArgs {
 	'unresponsive-sample-period'?: string;
 	'enable-rdp-display-tracking'?: boolean;
 	'disable-layout-restore'?: boolean;
+	'startup-experiment-group'?: string;
 
 	// chromium command line args: https://electronjs.org/docs/all#supported-chrome-command-line-switches
 	'no-proxy-server'?: boolean;

src/vs/platform/environment/node/argv.ts

@@ -200,6 +200,7 @@ export const OPTIONS: OptionDescriptions<Required<NativeParsedArgs>> = {
 	'unresponsive-sample-period': { type: 'string' },
 	'enable-rdp-display-tracking': { type: 'boolean' },
 	'disable-layout-restore': { type: 'boolean' },
+	'startup-experiment-group': { type: 'string', cat: 't', args: 'control|maximizedChat|splitEmptyEditorChat|splitWelcomeChat', description: localize('startupExperimentGroup', "Override the startup experiment group.") },
 
 	// chromium flags
 	'no-proxy-server': { type: 'boolean' },

src/vs/workbench/services/coreExperimentation/common/coreExperimentationService.ts

@@ -10,6 +10,7 @@ import { IStorageService, StorageScope, StorageTarget } from '../../../../platfo
 import { firstSessionDateStorageKey, ITelemetryService } from '../../../../platform/telemetry/common/telemetry.js';
 import { createDecorator } from '../../../../platform/instantiation/common/instantiation.js';
 import { IContextKeyService, RawContextKey } from '../../../../platform/contextkey/common/contextkey.js';
+import { IWorkbenchEnvironmentService } from '../../environment/common/environmentService.js';
 
 export const ICoreExperimentationService = createDecorator<ICoreExperimentationService>('coreExperimentationService');
 export const startupExpContext = new RawContextKey<string>('coreExperimentation.startupExpGroup', '');
@@ -83,7 +84,8 @@ export class CoreExperimentationService extends Disposable implements ICoreExper
 		@IStorageService private readonly storageService: IStorageService,
 		@ITelemetryService private readonly telemetryService: ITelemetryService,
 		@IProductService private readonly productService: IProductService,
-		@IContextKeyService private readonly contextKeyService: IContextKeyService
+		@IContextKeyService private readonly contextKeyService: IContextKeyService,
+		@IWorkbenchEnvironmentService private readonly environmentService: IWorkbenchEnvironmentService,
 	) {
 		super();
 		this.initializeExperiments();
@@ -141,6 +143,22 @@ export class CoreExperimentationService extends Disposable implements ICoreExper
 	}
 
 	private createStartupExperiment(experimentName: string, experimentConfig: ExperimentConfiguration): IExperiment | undefined {
+		const startupExpGroupOverride = this.environmentService.startupExperimentGroup;
+		if (startupExpGroupOverride) {
+			// If the user has an override, we use that directly
+			const group = experimentConfig.groups.find(g => g.name === startupExpGroupOverride);
+			if (group) {
+				return {
+					cohort: 1,
+					subCohort: 1,
+					experimentGroup: group.name,
+					iteration: group.iteration,
+					isInExperiment: true
+				};
+			}
+			return undefined;
+		}
+
 		const cohort = Math.random();
 
 		if (cohort >= experimentConfig.targetPercentage / 100) {

src/vs/workbench/services/coreExperimentation/test/browser/coreExperimentationService.test.ts

@@ -11,6 +11,7 @@ import { firstSessionDateStorageKey, ITelemetryService, ITelemetryData, Telemetr
 import { StorageScope, StorageTarget } from '../../../../../platform/storage/common/storage.js';
 import { TestStorageService } from '../../../../test/common/workbenchTestServices.js';
 import { IProductService } from '../../../../../platform/product/common/productService.js';
+import { IWorkbenchEnvironmentService } from '../../../environment/common/environmentService.js';
 
 interface ITelemetryEvent {
 	eventName: string;
@@ -72,12 +73,14 @@ suite('CoreExperimentationService', () => {
 	let telemetryService: MockTelemetryService;
 	let productService: MockProductService;
 	let contextKeyService: MockContextKeyService;
+	let environmentService: IWorkbenchEnvironmentService;
 
 	setup(() => {
 		storageService = disposables.add(new TestStorageService());
 		telemetryService = new MockTelemetryService();
 		productService = new MockProductService();
 		contextKeyService = new MockContextKeyService();
+		environmentService = {} as IWorkbenchEnvironmentService;
 	});
 
 	test('should return experiment from storage if it exists', () => {
@@ -97,7 +100,8 @@ suite('CoreExperimentationService', () => {
 			storageService,
 			telemetryService,
 			productService,
-			contextKeyService
+			contextKeyService,
+			environmentService
 		));
 
 		// Should not return experiment again
@@ -120,7 +124,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			// Should create experiment
@@ -154,7 +159,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			const experiment = service.getExperiment();
@@ -191,7 +197,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			// Should not create experiment
@@ -229,7 +236,8 @@ suite('CoreExperimentationService', () => {
 					storageService,
 					telemetryService,
 					productService,
-					contextKeyService
+					contextKeyService,
+					environmentService
 				));
 
 				const experiment = service.getExperiment();
@@ -254,7 +262,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			const experiment = service.getExperiment();
@@ -285,7 +294,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			const experiment = service.getExperiment();
@@ -309,7 +319,8 @@ suite('CoreExperimentationService', () => {
 				storageService,
 				telemetryService,
 				productService,
-				contextKeyService
+				contextKeyService,
+				environmentService
 			));
 
 			const experiment = service.getExperiment();

src/vs/workbench/services/environment/common/environmentService.ts

@@ -36,6 +36,7 @@ export interface IWorkbenchEnvironmentService extends IEnvironmentService {
 	readonly skipWelcome: boolean;
 	readonly disableWorkspaceTrust: boolean;
 	readonly webviewExternalEndpoint: string;
+	readonly startupExperimentGroup?: string;
 
 	// --- Development
 	readonly debugRenderer: boolean;

src/vs/workbench/services/environment/electron-browser/environmentService.ts

@@ -147,6 +147,15 @@ export class NativeWorkbenchEnvironmentService extends AbstractNativeEnvironment
 	@memoize
 	get filesToWait(): IPathsToWaitFor | undefined { return this.configuration.filesToWait; }
 
+	@memoize
+	get startupExperimentGroup(): string | undefined {
+		const group = this.args['startup-experiment-group'];
+		if (typeof group === 'string') {
+			return group;
+		}
+		return undefined;
+	}
+
 	constructor(
 		private readonly configuration: INativeWindowConfiguration,
 		productService: IProductService