Temporarily disable input method interception. (microsoft#159699)

* Temporarily disable input method interception. fixes microsoft#151496
rebase, sync fork
Author:    guttyon <[email protected]>
interactive rebase in progress; onto 851a0da
Last command done (1 command done):
   pick e021b16 Temporarily disable input method interception. fixes microsoft#151496
Next command to do (1 remaining command):
   pick 07b3ec4be36 add keybindingChordMode. move ime code into if-closure in _leaveChordMode. Because original code is called multi time while typing key.
You are currently rebasing branch 'temporarily_disable_input_method_interception' on '851a0dad5dd'.

* add keybindingChordMode. move ime code into if-closure in _leaveChordMode. Because original code is called multi time while typing key.

* remove ipcRender.send

* remove ffi-napi

* remove \n

* Added to test that the keybindingChordMode command is called.

* Make all editors readonly when in chord mode to suppress composing

Co-authored-by: vsgutcode <[email protected]>
Co-authored-by: Alexandru Dima <[email protected]>

Author: 3 people

src/vs/base/common/ime.ts

@@ -0,0 +1,36 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { Emitter } from 'vs/base/common/event';
+
+export class IMEImpl {
+
+	private readonly _onDidChange = new Emitter<void>();
+	public readonly onDidChange = this._onDidChange.event;
+
+	private _enabled = true;
+
+	public get enabled() {
+		return this._enabled;
+	}
+
+	/**
+	 * Enable IME
+	 */
+	public enable(): void {
+		this._enabled = true;
+		this._onDidChange.fire();
+	}
+
+	/**
+	 * Disable IME
+	 */
+	public disable(): void {
+		this._enabled = false;
+		this._onDidChange.fire();
+	}
+}
+
+export const IME = new IMEImpl();

src/vs/editor/browser/controller/textAreaHandler.ts

@@ -35,6 +35,7 @@ import { TokenizationRegistry } from 'vs/editor/common/languages';
 import { ColorId, ITokenPresentation } from 'vs/editor/common/encodedTokenAttributes';
 import { Color } from 'vs/base/common/color';
 import { TimeoutTimer } from 'vs/base/common/async';
+import { IME } from 'vs/base/common/ime';
 
 export interface IVisibleRangeProvider {
 	visibleRangeForPosition(position: Position): HorizontalPosition | null;
@@ -186,9 +187,7 @@ export class TextAreaHandler extends ViewPart {
 		this.textArea.setAttribute('aria-haspopup', 'false');
 		this.textArea.setAttribute('aria-autocomplete', 'both');
 
-		if (options.get(EditorOption.domReadOnly) && options.get(EditorOption.readOnly)) {
-			this.textArea.setAttribute('readonly', 'true');
-		}
+		this._ensureReadOnlyAttribute();
 
 		this.textAreaCover = createFastDomNode(document.createElement('div'));
 		this.textAreaCover.setPosition('absolute');
@@ -464,6 +463,10 @@ export class TextAreaHandler extends ViewPart {
 		this._register(this._textAreaInput.onBlur(() => {
 			this._context.viewModel.setHasFocus(false);
 		}));
+
+		this._register(IME.onDidChange(() => {
+			this._ensureReadOnlyAttribute();
+		}));
 	}
 
 	public override dispose(): void {
@@ -595,11 +598,7 @@ export class TextAreaHandler extends ViewPart {
 		this.textArea.setAttribute('tabindex', String(options.get(EditorOption.tabIndex)));
 
 		if (e.hasChanged(EditorOption.domReadOnly) || e.hasChanged(EditorOption.readOnly)) {
-			if (options.get(EditorOption.domReadOnly) && options.get(EditorOption.readOnly)) {
-				this.textArea.setAttribute('readonly', 'true');
-			} else {
-				this.textArea.removeAttribute('readonly');
-			}
+			this._ensureReadOnlyAttribute();
 		}
 
 		if (e.hasChanged(EditorOption.accessibilitySupport)) {
@@ -680,6 +679,18 @@ export class TextAreaHandler extends ViewPart {
 
 	// --- end view API
 
+	private _ensureReadOnlyAttribute(): void {
+		const options = this._context.configuration.options;
+		// When someone requests to disable IME, we set the "readonly" attribute on the <textarea>.
+		// This will prevent composition.
+		const useReadOnly = !IME.enabled || (options.get(EditorOption.domReadOnly) && options.get(EditorOption.readOnly));
+		if (useReadOnly) {
+			this.textArea.setAttribute('readonly', 'true');
+		} else {
+			this.textArea.removeAttribute('readonly');
+		}
+	}
+
 	private _primaryCursorPosition: Position = new Position(1, 1);
 	private _primaryCursorVisibleRange: HorizontalPosition | null = null;
 

src/vs/platform/keybinding/common/abstractKeybindingService.ts

@@ -19,6 +19,7 @@ import { ResolvedKeybindingItem } from 'vs/platform/keybinding/common/resolvedKe
 import { ILogService } from 'vs/platform/log/common/log';
 import { INotificationService } from 'vs/platform/notification/common/notification';
 import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
+import { IME } from 'vs/base/common/ime';
 
 interface CurrentChord {
 	keypress: string;
@@ -164,6 +165,7 @@ export abstract class AbstractKeybindingService extends Disposable implements IK
 			}
 
 		}, 500);
+		IME.disable();
 	}
 
 	private _leaveChordMode(): void {
@@ -173,6 +175,7 @@ export abstract class AbstractKeybindingService extends Disposable implements IK
 		}
 		this._currentChordChecker.cancel();
 		this._currentChord = null;
+		IME.enable();
 	}
 
 	public dispatchByUserSettingsLabel(userSettingsLabel: string, target: IContextKeyServiceTarget): void {