Merge pull request microsoft#196618 from microsoft/tyriar/195704

Tyriar · web-flow · commit 267d00c5b143 · 2023-10-25T10:08:01.000-07:00
Fix parent element of term quick pick popup
diff --git a/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts b/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts
@@ -292,7 +292,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,
 			updateLayout(this._configurationService, e);
 			this._audioCueService.playAudioCue(AudioCue.terminalQuickFix);
 
-			const parentElement = e.closest('.xterm') as HTMLElement;
+			const parentElement = (e.closest('.xterm') as HTMLElement).parentElement;
 			if (!parentElement) {
 				return;
 			}

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon,`
`292`	`292`	`updateLayout(this._configurationService, e);`
`293`	`293`	`this._audioCueService.playAudioCue(AudioCue.terminalQuickFix);`
`294`	`294`
`295`		`- const parentElement = e.closest('.xterm') as HTMLElement;`
	`295`	`+ const parentElement = (e.closest('.xterm') as HTMLElement).parentElement;`
`296`	`296`	`if (!parentElement) {`
`297`	`297`	`return;`
`298`	`298`	`}`