Skip to content

Commit 268f1f1

Browse files
authored
Parse Notebook cell uris (microsoft#250261)
* Parse Notebook cell uris * Updates
1 parent a4dc6e5 commit 268f1f1

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/vs/workbench/contrib/notebook/common/notebookEditorModelResolverServiceImpl.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import { IConfigurationService } from '../../../../platform/configuration/common
2323
import { IFileReadLimits } from '../../../../platform/files/common/files.js';
2424
import { ITelemetryService } from '../../../../platform/telemetry/common/telemetry.js';
2525
import { INotebookLoggingService } from './notebookLoggingService.js';
26+
import { parse } from '../../../services/notebook/common/notebookDocumentService.js';
2627

2728
class NotebookModelReferenceCollection extends ReferenceCollection<Promise<IResolvedNotebookEditorModel>> {
2829

@@ -207,7 +208,11 @@ export class NotebookModelResolverServiceImpl implements INotebookEditorModelRes
207208
}
208209

209210
if (uri?.scheme === CellUri.scheme) {
210-
throw new Error(`CANNOT open a cell-uri as notebook. Tried with ${uri.toString()}`);
211+
const originalUri = uri;
212+
uri = parse(uri)?.notebook;
213+
if (!uri) {
214+
throw new Error(`CANNOT open a cell-uri as notebook. Tried with ${originalUri.toString()}`);
215+
}
211216
}
212217

213218
const resource = this._uriIdentService.asCanonicalUri(uri ?? this.createUntitledUri(viewType!));

0 commit comments

Comments
 (0)