Don't handle events when quick pick is not visible (microsoft#223419)

TylerLeonhardt · web-flow · commit 26bdc0aaeeb2 · 2024-07-23T16:10:53.000-07:00
Fixes microsoft#223363
diff --git a/src/vs/platform/quickinput/browser/quickInput.ts b/src/vs/platform/quickinput/browser/quickInput.ts
@@ -916,7 +916,7 @@ export class QuickPick<T extends IQuickPickItem> extends QuickInput implements I
 				}
 			}));
 			this.visibleDisposables.add(this.ui.list.onChangedCheckedElements(checkedItems => {
-				if (!this.canSelectMany) {
+				if (!this.canSelectMany || !this.visible) {
 					return;
 				}
 				if (this.selectedItemsToConfirm !== this._selectedItems && equals(checkedItems, this._selectedItems, (a, b) => a === b)) {

Original file line number	Diff line number	Diff line change
`@@ -916,7 +916,7 @@ export class QuickPick<T extends IQuickPickItem> extends QuickInput implements I`
`916`	`916`	`}`
`917`	`917`	`}));`
`918`	`918`	`this.visibleDisposables.add(this.ui.list.onChangedCheckedElements(checkedItems => {`
`919`		`- if (!this.canSelectMany) {`
	`919`	`+ if (!this.canSelectMany \|\| !this.visible) {`
`920`	`920`	`return;`
`921`	`921`	`}`
`922`	`922`	`if (this.selectedItemsToConfirm !== this._selectedItems && equals(checkedItems, this._selectedItems, (a, b) => a === b)) {`