Skip to content

Commit 26d5de2

Browse files
committed
Set default icon for test tasks to beaker
Fixes microsoft#152057
1 parent 9e1f017 commit 26d5de2

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/b
5252
import { INotificationService } from 'vs/platform/notification/common/notification';
5353
import { ThemeIcon } from 'vs/platform/theme/common/themeService';
5454
import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings';
55+
import { GroupKind } from 'vs/workbench/contrib/tasks/common/taskConfiguration';
56+
import { Codicon } from 'vs/base/common/codicons';
5557

5658
interface ITerminalData {
5759
terminal: ITerminalInstance;
@@ -1029,13 +1031,21 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
10291031
os,
10301032
remoteAuthority: this._environmentService.remoteAuthority
10311033
});
1034+
let icon: URI | ThemeIcon | { light: URI; dark: URI } | undefined;
1035+
if (task.configurationProperties.icon) {
1036+
icon = ThemeIcon.fromId(task.configurationProperties.icon);
1037+
} else {
1038+
const taskGroupKind = task.configurationProperties.group ? GroupKind.to(task.configurationProperties.group) : undefined;
1039+
const kindId = typeof taskGroupKind === 'string' ? taskGroupKind : taskGroupKind?.kind;
1040+
icon = kindId === 'test' ? ThemeIcon.fromId(Codicon.beaker.id) : defaultProfile.icon;
1041+
}
10321042
shellLaunchConfig = {
10331043
name: terminalName,
10341044
type,
10351045
executable: defaultProfile.path,
10361046
args: defaultProfile.args,
10371047
env: { ...defaultProfile.env },
1038-
icon: task.configurationProperties.icon ? ThemeIcon.fromId(task.configurationProperties.icon) : defaultProfile.icon,
1048+
icon,
10391049
color: task.configurationProperties.color || defaultProfile.color,
10401050
waitOnExit
10411051
};

0 commit comments

Comments
 (0)