Fix Local Port Host setting

alexr00 · alexr00 · commit 27ef170cb56e · 2021-10-26T14:11:17.000+02:00
Fixes microsoft#135201
diff --git a/src/vs/platform/remote/node/tunnelService.ts b/src/vs/platform/remote/node/tunnelService.ts
@@ -147,7 +147,8 @@ export class BaseTunnelService extends AbstractTunnelService {
 	}
 
 	private get defaultTunnelHost(): string {
-		return (this.configurationService.getValue('remote.localPortHost') === 'localhost') ? '127.0.0.1' : '0.0.0.0';
+		const settingValue = this.configurationService.getValue('remote.localPortHost');
+		return (!settingValue || settingValue === 'localhost') ? '127.0.0.1' : '0.0.0.0';
 	}
 
 	protected retainOrCreateTunnel(addressProvider: IAddressProvider, remoteHost: string, remotePort: number, localPort: number | undefined, elevateIfNeeded: boolean, privacy: string, protocol?: string): Promise<RemoteTunnel | undefined> | undefined {

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,8 @@ export class BaseTunnelService extends AbstractTunnelService {`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`private get defaultTunnelHost(): string {`
`150`		`- return (this.configurationService.getValue('remote.localPortHost') === 'localhost') ? '127.0.0.1' : '0.0.0.0';`
	`150`	`+ const settingValue = this.configurationService.getValue('remote.localPortHost');`
	`151`	`+ return (!settingValue \|\| settingValue === 'localhost') ? '127.0.0.1' : '0.0.0.0';`
`151`	`152`	`}`
`152`	`153`
`153`	`154`	`protected retainOrCreateTunnel(addressProvider: IAddressProvider, remoteHost: string, remotePort: number, localPort: number \| undefined, elevateIfNeeded: boolean, privacy: string, protocol?: string): Promise<RemoteTunnel \| undefined> \| undefined {`