Fix NAN for edits in notebook (microsoft#242263)

rebornix · web-flow · commit 29b7ad23bb6b · 2025-02-28T02:25:52.000+01:00
diff --git a/src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedNotebookEntry.ts b/src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingModifiedNotebookEntry.ts
@@ -740,7 +740,7 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie
 		}, 0);
 
 		const totalNumberOfLines = this.modifiedModel.cells.reduce((totalLines, cell) => totalLines + (cell.textModel?.getLineCount() ?? 0), 0);
-		return Math.min(1, totalNumberOfUpdatedLines / totalNumberOfLines);
+		return totalNumberOfLines === 0 ? 0 : Math.min(1, totalNumberOfUpdatedLines / totalNumberOfLines);
 	}
 
 	override createSnapshot(requestId: string | undefined, undoStop: string | undefined): ISnapshotEntry {

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,7 @@ export class ChatEditingModifiedNotebookEntry extends AbstractChatEditingModifie`
`740`	`740`	`}, 0);`
`741`	`741`
`742`	`742`	`const totalNumberOfLines = this.modifiedModel.cells.reduce((totalLines, cell) => totalLines + (cell.textModel?.getLineCount() ?? 0), 0);`
`743`		`- return Math.min(1, totalNumberOfUpdatedLines / totalNumberOfLines);`
	`743`	`+ return totalNumberOfLines === 0 ? 0 : Math.min(1, totalNumberOfUpdatedLines / totalNumberOfLines);`
`744`	`744`	`}`
`745`	`745`
`746`	`746`	`override createSnapshot(requestId: string \| undefined, undoStop: string \| undefined): ISnapshotEntry {`