re-add terminal voice action, stop it when appropriate (microsoft#230552)

Author: meganrogge

src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts

@@ -62,6 +62,8 @@ import { renderStringAsPlaintext } from '../../../../../base/browser/markdownRen
 type VoiceChatSessionContext = 'view' | 'inline' | 'terminal' | 'quick' | 'editor';
 const VoiceChatSessionContexts: VoiceChatSessionContext[] = ['view', 'inline', 'terminal', 'quick', 'editor'];
 
+const TerminalChatExecute = MenuId.for('terminalChatInput'); // unfortunately, terminal decided to go with their own menu (https://github.com/microsoft/vscode/issues/208789)
+
 // Global Context Keys (set on global context key service)
 const CanVoiceChat = ContextKeyExpr.and(CONTEXT_CHAT_ENABLED, HasSpeechProvider);
 const FocusInChatInput = ContextKeyExpr.or(CTX_INLINE_CHAT_FOCUSED, CONTEXT_IN_CHAT_INPUT);
@@ -609,6 +611,16 @@ export class StartVoiceChatAction extends Action2 {
 					group: 'navigation',
 					order: 2
 				},
+				{
+					id: TerminalChatExecute,
+					when: ContextKeyExpr.and(
+						HasSpeechProvider,
+						ScopedChatSynthesisInProgress.negate(),	// hide when text to speech is in progress
+						AnyScopedVoiceChatInProgress?.negate(),	// hide when voice chat is in progress
+					),
+					group: 'navigation',
+					order: -1
+				},
 			]
 		});
 	}
@@ -656,6 +668,12 @@ export class StopListeningAction extends Action2 {
 					when: ContextKeyExpr.and(CONTEXT_CHAT_LOCATION.isEqualTo(ChatAgentLocation.Panel).negate(), AnyScopedVoiceChatInProgress),
 					group: 'navigation',
 					order: 2
+				}, {
+
+					id: TerminalChatExecute,
+					when: AnyScopedVoiceChatInProgress,
+					group: 'navigation',
+					order: -1
 				},
 			]
 		});
@@ -991,6 +1009,12 @@ export class StopReadAloud extends Action2 {
 					group: 'navigation',
 					order: 2
 				},
+				{
+					id: TerminalChatExecute,
+					when: ScopedChatSynthesisInProgress,
+					group: 'navigation',
+					order: -1
+				}
 			]
 		});
 	}
@@ -1325,9 +1349,14 @@ export class InstallSpeechProviderForVoiceChatAction extends BaseInstallSpeechPr
 			precondition: InstallingSpeechProvider.negate(),
 			menu: [{
 				id: MenuId.ChatInput,
-				when: HasSpeechProvider.negate(),
+				when: ContextKeyExpr.and(HasSpeechProvider.negate(), CONTEXT_CHAT_LOCATION.isEqualTo(ChatAgentLocation.Terminal).negate()),
 				group: 'navigation',
 				order: 3
+			}, {
+				id: TerminalChatExecute,
+				when: HasSpeechProvider.negate(),
+				group: 'navigation',
+				order: -1
 			}]
 		});
 	}

src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts

@@ -216,6 +216,7 @@ export class TerminalChatController extends Disposable implements ITerminalContr
 			await this.reveal();
 		}
 		assertType(this._model.value);
+		this._messages.fire(Message.ACCEPT_INPUT);
 		const lastInput = this._terminalChatWidget.value.inlineChatWidget.value;
 		if (!lastInput) {
 			return;