Revert "Delay PreferencesActionsContribution (microsoft#159719)" (microsoft#160333)

rzhao271 · web-flow · commit 2c1aee64455a · 2022-09-08T16:13:42.000-07:00
This reverts commit 3b26f30.
diff --git a/src/vs/workbench/contrib/preferences/browser/preferences.contribution.ts b/src/vs/workbench/contrib/preferences/browser/preferences.contribution.ts
@@ -1243,9 +1243,7 @@ class PreferencesActionsContribution extends Disposable implements IWorkbenchCon
 }
 
 const workbenchContributionsRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench);
-// PreferencesActionsContribution is heavy because it runs through various details to determine which actions to render.
-// We don't need it to start so early.
-workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Restored);
+workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Starting);
 workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesContribution, 'PreferencesContribution', LifecyclePhase.Starting);
 
 registerEditorContribution(SettingsEditorContribution.ID, SettingsEditorContribution);

Original file line number	Diff line number	Diff line change
`@@ -1243,9 +1243,7 @@ class PreferencesActionsContribution extends Disposable implements IWorkbenchCon`
`1243`	`1243`	`}`
`1244`	`1244`
`1245`	`1245`	`const workbenchContributionsRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench);`
`1246`		`-// PreferencesActionsContribution is heavy because it runs through various details to determine which actions to render.`
`1247`		`-// We don't need it to start so early.`
`1248`		`-workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Restored);`
	`1246`	`+workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Starting);`
`1249`	`1247`	`workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesContribution, 'PreferencesContribution', LifecyclePhase.Starting);`
`1250`	`1248`
`1251`	`1249`	`registerEditorContribution(SettingsEditorContribution.ID, SettingsEditorContribution);`