fix: make sure showKeybindings stills works in screencast mode (microsoft#202735)

joaomoreno · web-flow · commit 2cec7a8d8872 · 2024-01-18T16:07:13.000+01:00
fixes microsoft#201689
diff --git a/src/vs/workbench/browser/actions/developerActions.ts b/src/vs/workbench/browser/actions/developerActions.ts
@@ -350,7 +350,7 @@ class ToggleScreencastModeAction extends Action2 {
 				append(keyboardMarker, $('span.title', {}, `${commandAndGroupLabel} `));
 			}
 
-			if ((options.showKeys ?? true) || (commandDetails && (options.showKeybindings ?? true))) {
+			if ((options.showKeys ?? true) || ((options.showKeybindings ?? true) && this._isKbFound(shortcut))) {
 				// Fix label for arrow keys
 				keyLabel = keyLabel?.replace('UpArrow', '↑')
 					?.replace('DownArrow', '↓')

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ class ToggleScreencastModeAction extends Action2 {`
`350`	`350`	append(keyboardMarker, $('span.title', {}, `${commandAndGroupLabel} `));
`351`	`351`	`}`
`352`	`352`
`353`		`- if ((options.showKeys ?? true) \|\| (commandDetails && (options.showKeybindings ?? true))) {`
	`353`	`+ if ((options.showKeys ?? true) \|\| ((options.showKeybindings ?? true) && this._isKbFound(shortcut))) {`
`354`	`354`	`// Fix label for arrow keys`
`355`	`355`	`keyLabel = keyLabel?.replace('UpArrow', '↑')`
`356`	`356`	`?.replace('DownArrow', '↓')`