debug: address triggered breakpoint feedback (microsoft#203363)

Fixes microsoft#203154
Fixes microsoft#203155
Fixes microsoft#203156
Fixes microsoft#203158

Author: connor4312

src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts

@@ -457,7 +457,7 @@ export class BreakpointEditorContribution implements IBreakpointEditorContributi
 			));
 			actions.push(new Action(
 				'addTriggeredBreakpoint',
-				nls.localize('addTriggeredBreakpoint', "Add Triggered Breakpoint.."),
+				nls.localize('addTriggeredBreakpoint', "Add Triggered Breakpoint..."),
 				undefined,
 				true,
 				() => Promise.resolve(this.showBreakpointWidget(lineNumber, column, BreakpointWidgetContext.TRIGGER_POINT))

src/vs/workbench/contrib/debug/browser/breakpointWidget.ts

@@ -84,6 +84,7 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 	private inputContainer!: HTMLElement;
 	private selectBreakpointContainer!: HTMLElement;
 	private input!: IActiveCodeEditor;
+	private selectBreakpointBox!: SelectBox;
 	private toDispose: lifecycle.IDisposable[];
 	private conditionInput = '';
 	private hitCountInput = '';
@@ -205,7 +206,7 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 			{ text: nls.localize('expression', "Expression") },
 			{ text: nls.localize('hitCount', "Hit Count") },
 			{ text: nls.localize('logMessage', "Log Message") },
-			{ text: nls.localize('triggeredBy', "Wait For Breakpoint") },
+			{ text: nls.localize('triggeredBy', "Wait for Breakpoint") },
 		], this.context, this.contextViewService, defaultSelectBoxStyles, { ariaLabel: nls.localize('breakpointType', 'Breakpoint Type') });
 		this.selectContainer = $('.breakpoint-select-container');
 		selectBox.render(dom.append(container, this.selectContainer));
@@ -228,7 +229,7 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 
 		this.updateContextInput();
 		// Due to an electron bug we have to do the timeout, otherwise we do not get focus
-		setTimeout(() => this.input.focus(), 150);
+		setTimeout(() => this.focusInput(), 150);
 	}
 
 	private createTriggerBreakpointInput(container: HTMLElement) {
@@ -256,7 +257,7 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 			], select);
 		});
 
-		const selectBreakpointBox = new SelectBox([{ text: nls.localize('triggerByLoading', 'Loading...'), isDisabled: true }], 0, this.contextViewService, defaultSelectBoxStyles, { ariaLabel: nls.localize('selectBreakpoint', 'Select breakpoint') });
+		const selectBreakpointBox = this.selectBreakpointBox = new SelectBox([{ text: nls.localize('triggerByLoading', 'Loading...'), isDisabled: true }], 0, this.contextViewService, defaultSelectBoxStyles, { ariaLabel: nls.localize('selectBreakpoint', 'Select breakpoint') });
 		selectBreakpointBox.onDidSelect(e => {
 			if (e.index === 0) {
 				this.triggeredByBreakpointInput = undefined;
@@ -295,7 +296,7 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 			this.setInputMode();
 			const value = this.getInputValue(this.breakpoint);
 			this.input.getModel().setValue(value);
-			this.input.focus();
+			this.focusInput();
 		}
 	}
 
@@ -455,6 +456,14 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi
 		this.dispose();
 	}
 
+	private focusInput() {
+		if (this.context === Context.TRIGGER_POINT) {
+			this.selectBreakpointBox.focus();
+		} else {
+			this.input.focus();
+		}
+	}
+
 	override dispose(): void {
 		super.dispose();
 		this.input.dispose();

src/vs/workbench/contrib/debug/browser/media/debug.contribution.css

@@ -31,6 +31,9 @@
 	margin-top: -1px;
 }
 
+
+.codicon-debug-breakpoint-conditional.codicon-debug-stackframe-focused::after,
+.codicon-debug-breakpoint-conditional.codicon-debug-stackframe::after,
 .codicon-debug-breakpoint.codicon-debug-stackframe-focused::after,
 .codicon-debug-breakpoint.codicon-debug-stackframe::after {
 	content: '\eb8a';