Skip to content

Commit 2da60fd

Browse files
authored
Update quick pick placeholders and/or remove titles (microsoft#165267)
1 parent 87bf037 commit 2da60fd

File tree

9 files changed

+12
-14
lines changed

9 files changed

+12
-14
lines changed

extensions/git/src/commands.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2007,8 +2007,8 @@ export class CommandCenter {
20072007
const quickpick = window.createQuickPick();
20082008
quickpick.items = picks;
20092009
quickpick.placeholder = opts?.detached
2010-
? l10n.t('Select a ref to checkout in detached mode')
2011-
: l10n.t('Select a ref to checkout');
2010+
? l10n.t('Select a branch or tag to checkout in detached mode')
2011+
: l10n.t('Select a branch or tag to checkout');
20122012

20132013
quickpick.show();
20142014

extensions/json-language-features/client/src/languageStatus.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ function showSchemaList(input: ShowSchemasInput) {
149149
items.push({ label: localize('schema.showdocs', 'Learn more about JSON schema configuration...'), uri: Uri.parse('https://code.visualstudio.com/docs/languages/json#_json-schemas-and-settings') });
150150

151151
const quickPick = window.createQuickPick<ShowSchemasItem>();
152-
quickPick.title = localize('schemaPicker.title', 'JSON Schemas used for {0}', input.uri);
153-
// quickPick.placeholder = items.length ? localize('schemaPicker.placeholder', 'Select the schema to open') : undefined;
152+
quickPick.placeholder = items.length ? localize('schemaPicker.placeholder', 'Select the schema to use for {0}', input.uri) : undefined;
154153
quickPick.items = items;
155154
quickPick.show();
156155
quickPick.onDidAccept(() => {

extensions/npm/src/commands.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ export async function selectAndRunScriptFromFolder(context: vscode.ExtensionCont
4141

4242
if (taskList && taskList.length > 0) {
4343
const quickPick = vscode.window.createQuickPick<IFolderTaskItem>();
44-
quickPick.title = 'Run NPM script in Folder';
45-
quickPick.placeholder = 'Select an npm script';
44+
quickPick.placeholder = 'Select an npm script to run in folder';
4645
quickPick.items = taskList;
4746

4847
const toDispose: vscode.Disposable[] = [];

src/vs/workbench/contrib/editSessions/browser/editSessions.contribution.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -748,8 +748,7 @@ export class EditSessionsContribution extends Disposable implements IWorkbenchCo
748748
const workspaceContext = this.contextService.getWorkbenchState() === WorkbenchState.FOLDER
749749
? this.contextService.getWorkspace().folders[0].name
750750
: this.contextService.getWorkspace().folders.map((folder) => folder.name).join(', ');
751-
quickPick.title = localize('continueEditSessionPick.title', "Continue {0} on", `'${workspaceContext}'`);
752-
quickPick.placeholder = localize('continueEditSessionPick.placeholder', 'Choose how you would like to continue working');
751+
quickPick.placeholder = localize('continueEditSessionPick.title', "Select option to continue {0} on", `'${workspaceContext}'`);
753752
quickPick.items = this.createPickItems();
754753

755754
const command = await new Promise<string | undefined>((resolve, reject) => {

src/vs/workbench/contrib/editSessions/browser/editSessionsStorageService.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,9 +294,8 @@ export class EditSessionsWorkbenchService extends Disposable implements IEditSes
294294
*/
295295
private async getAccountPreference(fromContinueOn: boolean): Promise<AuthenticationSession & { providerId: string } | undefined> {
296296
const quickpick = this.quickInputService.createQuickPick<ExistingSession | AuthenticationProviderOption | IQuickPickItem>();
297-
quickpick.title = localize('account preference', 'Turn on Edit Sessions to bring your working changes with you');
298297
quickpick.ok = false;
299-
quickpick.placeholder = localize('choose account placeholder', "Select an account to sign in");
298+
quickpick.placeholder = localize('choose account placeholder', "Select an account to turn on Edit Sessions");
300299
quickpick.ignoreFocusOut = true;
301300
quickpick.items = await this.createQuickpickItems(fromContinueOn);
302301

src/vs/workbench/contrib/remote/browser/remoteIndicator.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,7 @@ export class RemoteStatusIndicator extends Disposable implements IWorkbenchContr
472472
};
473473

474474
const quickPick = this.quickInputService.createQuickPick();
475+
quickPick.placeholder = nls.localize('remoteActions', "Select an option to open a Remote Window");
475476
quickPick.items = computeItems();
476477
quickPick.sortByLabel = false;
477478
quickPick.canSelectMany = false;

src/vs/workbench/contrib/remoteTunnel/electron-sandbox/remoteTunnel.contribution.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,9 +260,8 @@ export class RemoteTunnelWorkbenchContribution extends Disposable implements IWo
260260

261261
private async getAccountPreference(): Promise<ExistingSessionItem | undefined> {
262262
const quickpick = this.quickInputService.createQuickPick<ExistingSessionItem | AuthenticationProviderOption | IQuickPickItem>();
263-
quickpick.title = localize('accountPreference.title', 'Enable remote access by signing up to remote tunnels.');
264263
quickpick.ok = false;
265-
quickpick.placeholder = localize('accountPreference.placeholder', "Select an account to sign in");
264+
quickpick.placeholder = localize('accountPreference.placeholder', "Sign in to an account to enable remote access");
266265
quickpick.ignoreFocusOut = true;
267266
quickpick.items = await this.createQuickpickItems();
268267

src/vs/workbench/contrib/userDataProfile/browser/userDataProfileActions.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ export class RenameProfileAction extends Action2 {
219219

220220
const name = await quickInputService.input({
221221
value: profile.name,
222-
title: localize('edit settings profile', "Rename Settings Profile..."),
222+
title: localize('select settings profile to rename', 'Rename {0}', profile.name),
223223
validateInput: async (value: string) => {
224224
if (profile!.name !== value && userDataProfilesService.profiles.some(p => p.name === value)) {
225225
return localize('profileExists', "Settings Profile with name {0} already exists.", value);
@@ -248,6 +248,7 @@ export class RenameProfileAction extends Action2 {
248248
profile
249249
})),
250250
{
251+
title: localize('rename specific settings profile', "Rename Settings Profile..."),
251252
placeHolder: localize('pick profile to rename', "Select Settings Profile to Rename"),
252253
});
253254
return pick?.profile;
@@ -294,6 +295,7 @@ registerAction2(class DeleteProfileAction extends Action2 {
294295
profile
295296
})),
296297
{
298+
title: localize('delete specific settings profile', "Delete Settings Profile..."),
297299
placeHolder: localize('pick profile to delete', "Select Settings Profiles to Delete"),
298300
canPickMany: true
299301
});

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.contribution.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ registerAction2(class extends Action2 {
232232
quickPick.canSelectMany = false;
233233
quickPick.matchOnDescription = true;
234234
quickPick.matchOnDetail = true;
235-
quickPick.title = localize('pickWalkthroughs', "Open Walkthrough...");
235+
quickPick.placeholder = localize('pickWalkthroughs', 'Select a walkthrough to open');
236236
quickPick.items = this.getQuickPickItems(contextService, gettingStartedService);
237237
quickPick.busy = true;
238238
quickPick.onDidAccept(() => {

0 commit comments

Comments
 (0)