Merge pull request microsoft#192913 from microsoft/aamunger/releaseErrorLinks

amunger · web-flow · commit 2db1f3b13eef · 2023-09-12T14:53:22.000-07:00
prioritize html links since they can wrap other link types
diff --git a/extensions/notebook-renderers/src/linkify.ts b/extensions/notebook-renderers/src/linkify.ts
@@ -142,8 +142,8 @@ export class LinkDetector {
 			return [{ kind: 'text', value: text, captures: [] }];
 		}
 
-		const regexes: RegExp[] = [WEB_LINK_REGEX, PATH_LINK_REGEX, HTML_LINK_REGEX];
-		const kinds: LinkKind[] = ['web', 'path', 'html'];
+		const regexes: RegExp[] = [HTML_LINK_REGEX, WEB_LINK_REGEX, PATH_LINK_REGEX];
+		const kinds: LinkKind[] = ['html', 'web', 'path'];
 		const result: LinkPart[] = [];
 
 		const splitOne = (text: string, regexIndex: number) => {

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,8 @@ export class LinkDetector {`
`142`	`142`	`return [{ kind: 'text', value: text, captures: [] }];`
`143`	`143`	`}`
`144`	`144`
`145`		`- const regexes: RegExp[] = [WEB_LINK_REGEX, PATH_LINK_REGEX, HTML_LINK_REGEX];`
`146`		`- const kinds: LinkKind[] = ['web', 'path', 'html'];`
	`145`	`+ const regexes: RegExp[] = [HTML_LINK_REGEX, WEB_LINK_REGEX, PATH_LINK_REGEX];`
	`146`	`+ const kinds: LinkKind[] = ['html', 'web', 'path'];`
`147`	`147`	`const result: LinkPart[] = [];`
`148`	`148`
`149`	`149`	`const splitOne = (text: string, regexIndex: number) => {`