use name property for errornotelemetry (microsoft#151974)

* use name property for errornotelemetry

* fix ENOPRO errors

* fileoperationerror extends error now

Author: sbatten

src/vs/base/common/errors.ts

@@ -23,6 +23,10 @@ export class ErrorHandler {
 		this.unexpectedErrorHandler = function (e: any) {
 			setTimeout(() => {
 				if (e.stack) {
+					if (ErrorNoTelemetry.isErrorNoTelemetry(e)) {
+						throw new ErrorNoTelemetry(e.message + '\n\n' + e.stack);
+					}
+
 					throw new Error(e.message + '\n\n' + e.stack);
 				}
 
@@ -109,7 +113,7 @@ export function transformErrorForSerialization(error: any): any {
 			name,
 			message,
 			stack,
-			noTelemetry: error instanceof ErrorNoTelemetry
+			noTelemetry: ErrorNoTelemetry.isErrorNoTelemetry(error)
 		};
 	}
 
@@ -235,24 +239,27 @@ export class ExpectedError extends Error {
  * Error that when thrown won't be logged in telemetry as an unhandled error.
  */
 export class ErrorNoTelemetry extends Error {
+	override readonly name: string;
 
-	public static fromError(err: any): ErrorNoTelemetry {
-		if (err && err instanceof ErrorNoTelemetry) {
-			return err;
-		}
+	constructor(msg?: string) {
+		super(msg);
+		this.name = 'ErrorNoTelemetry';
+	}
 
-		if (err && err instanceof Error) {
-			const result = new ErrorNoTelemetry();
-			result.name = err.name;
-			result.message = err.message;
-			result.stack = err.stack;
-			return result;
+	public static fromError(err: Error): ErrorNoTelemetry {
+		if (err instanceof ErrorNoTelemetry) {
+			return err;
 		}
 
-		return new ErrorNoTelemetry(err);
+		const result = new ErrorNoTelemetry();
+		result.message = err.message;
+		result.stack = err.stack;
+		return result;
 	}
 
-	readonly logTelemetry = false;
+	public static isErrorNoTelemetry(err: Error): err is ErrorNoTelemetry {
+		return err.name === 'ErrorNoTelemetry';
+	}
 }
 
 /**

src/vs/platform/files/common/fileService.ts

@@ -7,7 +7,6 @@ import { coalesce } from 'vs/base/common/arrays';
 import { Promises, ResourceQueue } from 'vs/base/common/async';
 import { bufferedStreamToBuffer, bufferToReadable, newWriteableBufferStream, readableToBuffer, streamToBuffer, VSBuffer, VSBufferReadable, VSBufferReadableBufferedStream, VSBufferReadableStream } from 'vs/base/common/buffer';
 import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation';
-import { ErrorNoTelemetry } from 'vs/base/common/errors';
 import { Emitter } from 'vs/base/common/event';
 import { hash } from 'vs/base/common/hash';
 import { Iterable } from 'vs/base/common/iterator';
@@ -137,7 +136,7 @@ export class FileService extends Disposable implements IFileService {
 		// Assert provider
 		const provider = this.provider.get(resource.scheme);
 		if (!provider) {
-			const error = new ErrorNoTelemetry();
+			const error = new Error();
 			error.name = 'ENOPRO';
 			error.message = localize('noProviderFound', "No file system provider found for resource '{0}'", resource.toString());
 

src/vs/platform/files/common/files.ts

@@ -5,7 +5,6 @@
 
 import { VSBuffer, VSBufferReadable, VSBufferReadableStream } from 'vs/base/common/buffer';
 import { CancellationToken } from 'vs/base/common/cancellation';
-import { ErrorNoTelemetry } from 'vs/base/common/errors';
 import { Event } from 'vs/base/common/event';
 import { IExpression, IRelativePattern } from 'vs/base/common/glob';
 import { IDisposable } from 'vs/base/common/lifecycle';
@@ -1148,7 +1147,7 @@ export interface ICreateFileOptions {
 	readonly overwrite?: boolean;
 }
 
-export class FileOperationError extends ErrorNoTelemetry {
+export class FileOperationError extends Error {
 	constructor(
 		message: string,
 		readonly fileOperationResult: FileOperationResult,

src/vs/platform/telemetry/browser/errorTelemetry.ts

@@ -39,7 +39,7 @@ export default class ErrorTelemetry extends BaseErrorTelemetry {
 
 		if (err) {
 			// If it's the no telemetry error it doesn't get logged
-			if (err instanceof ErrorNoTelemetry) {
+			if (ErrorNoTelemetry.isErrorNoTelemetry(err)) {
 				return;
 			}
 

src/vs/workbench/api/common/extHostFileSystem.ts

@@ -17,7 +17,6 @@ import { CharCode } from 'vs/base/common/charCode';
 import { VSBuffer } from 'vs/base/common/buffer';
 import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
 import { checkProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions';
-import { ErrorNoTelemetry } from 'vs/base/common/errors';
 
 class FsLinkProvider {
 
@@ -296,7 +295,7 @@ export class ExtHostFileSystem implements ExtHostFileSystemShape {
 	private _getFsProvider(handle: number): vscode.FileSystemProvider {
 		const provider = this._fsProvider.get(handle);
 		if (!provider) {
-			const err = new ErrorNoTelemetry();
+			const err = new Error();
 			err.name = 'ENOPRO';
 			err.message = `no provider`;
 			throw err;