testing: coverage decorations in high contrast, better default behavior for position-only exts (microsoft#202676)

* testing: coverage decorations in high contrast, better default behavior for position-only exts

* update snapshot

Author: connor4312

build/lib/stylelint/vscode-known-variables.json

@@ -680,8 +680,9 @@
 		"--vscode-terminalOverviewRuler-findMatchForeground",
 		"--vscode-terminalStickyScroll-background",
 		"--vscode-terminalStickyScrollHover-background",
-		"--vscode-testing-coveredBackground",
 		"--vscode-testing-coverage-lineHeight",
+		"--vscode-testing-coveredBackground",
+		"--vscode-testing-coveredBorder",
 		"--vscode-testing-coveredGutterBackground",
 		"--vscode-testing-iconErrored",
 		"--vscode-testing-iconFailed",
@@ -697,6 +698,7 @@
 		"--vscode-testing-peekHeaderBackground",
 		"--vscode-testing-runAction",
 		"--vscode-testing-uncoveredBackground",
+		"--vscode-testing-uncoveredBorder",
 		"--vscode-testing-uncoveredGutterBackground",
 		"--vscode-textBlockQuote-background",
 		"--vscode-textBlockQuote-border",

src/vs/workbench/contrib/testing/browser/codeCoverageDecorations.ts

@@ -452,7 +452,7 @@ export class CoverageDetailsModel {
 // and trailing whitespace.
 function tidyLocation(location: Range | Position): Range {
 	if (location instanceof Position) {
-		return Range.fromPositions(location);
+		return Range.fromPositions(location, new Position(location.lineNumber, 0x7FFFFFFF));
 	}
 
 	return location;

src/vs/workbench/contrib/testing/browser/media/testing.css

@@ -430,10 +430,19 @@
 
 .coverage-deco-gutter.coverage-deco-hit::before {
 	background: var(--vscode-testing-coveredGutterBackground);
+	border-color: var(--vscode-testing-coveredGutterBackground);
 }
 
 .coverage-deco-gutter.coverage-deco-miss::before {
 	background: var(--vscode-testing-uncoveredGutterBackground);
+	border-color: var(--vscode-testing-uncoveredGutterBackground);
+}
+
+.hc-light .coverage-deco-gutter::before,
+.hc-black .coverage-deco-gutter::before {
+	border-width: 3px 0 3px 5px;
+	border-style: solid;
+	background: none;
 }
 
 .coverage-deco-gutter.coverage-deco-miss.coverage-deco-hit::before {
@@ -456,10 +465,17 @@
 
 .coverage-deco-inline.coverage-deco-hit {
 	background: var(--vscode-testing-coveredBackground);
+	outline: 1px solid var(--vscode-testing-coveredBorder);
 }
 
 .coverage-deco-inline.coverage-deco-miss {
 	background: var(--vscode-testing-uncoveredBackground);
+	outline: 1px solid var(--vscode-testing-uncoveredBorder);
+}
+
+.hc-light .coverage-deco-inline.coverage-deco-hit,
+.hc-black .coverage-deco-inline.coverage-deco-hit {
+	outline-style: dashed;
 }
 
 .coverage-deco-branch-miss-indicator {

src/vs/workbench/contrib/testing/browser/theme.ts

@@ -5,7 +5,7 @@
 
 import { Color, RGBA } from 'vs/base/common/color';
 import { localize } from 'vs/nls';
-import { contrastBorder, diffInserted, diffRemoved, editorBackground, editorErrorForeground, editorForeground, editorInfoForeground, opaque, registerColor, transparent } from 'vs/platform/theme/common/colorRegistry';
+import { chartsGreen, chartsRed, contrastBorder, diffInserted, diffRemoved, editorBackground, editorErrorForeground, editorForeground, editorInfoForeground, opaque, registerColor, transparent } from 'vs/platform/theme/common/colorRegistry';
 import { registerThemingParticipant } from 'vs/platform/theme/common/themeService';
 import { TestMessageType, TestResultState } from 'vs/workbench/contrib/testing/common/testTypes';
 
@@ -93,11 +93,18 @@ export const testingCoveredBackground = registerColor('testing.coveredBackground
 	hcLight: null
 }, localize('testing.coveredBackground', 'Background color of text that was covered.'));
 
+export const testingCoveredBorder = registerColor('testing.coveredBorder', {
+	dark: transparent(testingCoveredBackground, 0.75),
+	light: transparent(testingCoveredBackground, 0.75),
+	hcDark: contrastBorder,
+	hcLight: contrastBorder
+}, localize('testing.coveredBorder', 'Border color of text that was covered.'));
+
 export const testingCoveredGutterBackground = registerColor('testing.coveredGutterBackground', {
 	dark: transparent(diffInserted, 0.6),
 	light: transparent(diffInserted, 0.6),
-	hcDark: null,
-	hcLight: null
+	hcDark: chartsGreen,
+	hcLight: chartsGreen
 }, localize('testing.coveredGutterBackground', 'Gutter color of regions where code was covered.'));
 
 export const testingUncoveredBranchBackground = registerColor('testing.uncoveredBranchBackground', {
@@ -114,11 +121,18 @@ export const testingUncoveredBackground = registerColor('testing.uncoveredBackgr
 	hcLight: null
 }, localize('testing.uncoveredBackground', 'Background color of text that was not covered.'));
 
+export const testingUncoveredBorder = registerColor('testing.uncoveredBorder', {
+	dark: transparent(testingUncoveredBackground, 0.75),
+	light: transparent(testingUncoveredBackground, 0.75),
+	hcDark: contrastBorder,
+	hcLight: contrastBorder
+}, localize('testing.uncoveredBorder', 'Border color of text that was not covered.'));
+
 export const testingUncoveredGutterBackground = registerColor('testing.uncoveredGutterBackground', {
 	dark: transparent(diffRemoved, 1.5),
 	light: transparent(diffRemoved, 1.5),
-	hcDark: null,
-	hcLight: null
+	hcDark: chartsRed,
+	hcLight: chartsRed
 }, localize('testing.uncoveredGutterBackground', 'Gutter color of regions where code not covered.'));
 
 export const testMessageSeverityColors: {
@@ -168,19 +182,13 @@ registerThemingParticipant((theme, collector) => {
 	const missBadgeBackground = editorBg && theme.getColor(testingUncoveredBackground)?.transparent(2).makeOpaque(editorBg);
 
 	collector.addRule(`
-	.coverage-deco-inline.coverage-deco-hit {
-		outline: 1px solid ${theme.getColor(testingCoveredBackground)?.transparent(0.75)};
-	}
 	.coverage-deco-inline.coverage-deco-hit.coverage-deco-hovered {
 		background: ${theme.getColor(testingCoveredBackground)?.transparent(1.3)};
-		outline: 1px solid ${theme.getColor(testingCoveredBackground)?.transparent(2)};
-	}
-	.coverage-deco-inline.coverage-deco-miss {
-		outline: 1px solid ${theme.getColor(testingUncoveredBackground)?.transparent(0.75)};
+		outline-color: ${theme.getColor(testingCoveredBorder)?.transparent(2)};
 	}
 	.coverage-deco-inline.coverage-deco-miss.coverage-deco-hovered {
 		background: ${theme.getColor(testingUncoveredBackground)?.transparent(1.3)};
-		outline: 1px solid ${theme.getColor(testingUncoveredBackground)?.transparent(2)};
+		outline-color: ${theme.getColor(testingUncoveredBorder)?.transparent(2)};
 	}
 	.coverage-deco-branch-miss-indicator::before {
 		border-color: ${missBadgeBackground?.transparent(1.3)};

src/vs/workbench/contrib/testing/test/browser/__snapshots__/Code_Coverage_Decorations_CoverageDetailsModel_4.0.snap

@@ -1,18 +1,26 @@
 [
   {
-    range: "[2,0 -> 2,0]",
+    range: "[1,0 -> 2,0]",
+    count: 1
+  },
+  {
+    range: "[2,0 -> 2,2147483647]",
     count: 2
   },
   {
-    range: "[1,0 -> 4,0]",
+    range: "[2,2147483647 -> 4,0]",
     count: 1
   },
   {
-    range: "[4,3 -> 4,3]",
+    range: "[4,0 -> 4,3]",
+    count: 3
+  },
+  {
+    range: "[4,3 -> 4,2147483647]",
     count: 4
   },
   {
-    range: "[4,0 -> 5,0]",
+    range: "[4,2147483647 -> 5,0]",
     count: 3
   }
 ]