Merge pull request microsoft#186562 from microsoft/aamunger/notebookToolbar

amunger · web-flow · commit 2e8ab0675518 · 2023-06-28T14:50:45.000-07:00
prevent exception during notebook toolbar layout call
diff --git a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorToolbar.ts b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorToolbar.ts
@@ -645,7 +645,7 @@ function actionOverflowHelper(initialPrimaryActions: IActionModel[], initialSeco
 		}
 	}
 
-	for (let i = (renderActions.length - 1); i !== 0; i--) {
+	for (let i = (renderActions.length - 1); i > 0; i--) {
 		const temp = renderActions[i];
 		if (temp.size === 0) {
 			continue;

Original file line number	Diff line number	Diff line change
`@@ -645,7 +645,7 @@ function actionOverflowHelper(initialPrimaryActions: IActionModel[], initialSeco`
`645`	`645`	`}`
`646`	`646`	`}`
`647`	`647`
`648`		`- for (let i = (renderActions.length - 1); i !== 0; i--) {`
	`648`	`+ for (let i = (renderActions.length - 1); i > 0; i--) {`
`649`	`649`	`const temp = renderActions[i];`
`650`	`650`	`if (temp.size === 0) {`
`651`	`651`	`continue;`