Chat copy polish (microsoft#252720)

microsoft/vscode-copilot-release#416

Author: roblourens

src/vs/workbench/contrib/chat/browser/actions/chatCopyActions.ts

@@ -3,14 +3,15 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import * as dom from '../../../../../base/browser/dom.js';
 import { ServicesAccessor } from '../../../../../editor/browser/editorExtensions.js';
 import { localize2 } from '../../../../../nls.js';
 import { Action2, MenuId, registerAction2 } from '../../../../../platform/actions/common/actions.js';
 import { IClipboardService } from '../../../../../platform/clipboard/common/clipboardService.js';
 import { CHAT_CATEGORY, stringifyItem } from './chatActions.js';
-import { IChatWidgetService } from '../chat.js';
+import { ChatTreeItem, IChatWidgetService } from '../chat.js';
 import { ChatContextKeys } from '../../common/chatContextKeys.js';
-import { IChatRequestViewModel, IChatResponseViewModel, isRequestVM, isResponseVM } from '../../common/chatViewModel.js';
+import { IChatRequestViewModel, IChatResponseViewModel, isChatTreeItem, isRequestVM, isResponseVM } from '../../common/chatViewModel.js';
 
 export function registerChatCopyActions() {
 	registerAction2(class CopyAllAction extends Action2 {
@@ -60,15 +61,30 @@ export function registerChatCopyActions() {
 			});
 		}
 
-		run(accessor: ServicesAccessor, ...args: any[]) {
-			const item = args[0];
-			if (!isRequestVM(item) && !isResponseVM(item)) {
+		async run(accessor: ServicesAccessor, ...args: any[]) {
+			const chatWidgetService = accessor.get(IChatWidgetService);
+			const clipboardService = accessor.get(IClipboardService);
+
+			const widget = chatWidgetService.lastFocusedWidget;
+			let item: ChatTreeItem | undefined = args[0];
+			if (!isChatTreeItem(item)) {
+				item = widget?.getFocus();
+				if (!item) {
+					return;
+				}
+			}
+
+			// If there is a text selection, and focus is inside the widget, copy the selected text.
+			// Otherwise, context menu with no selection -> copy the full item
+			const nativeSelection = dom.getActiveWindow().getSelection();
+			const selectedText = nativeSelection?.toString();
+			if (widget && selectedText && selectedText.length > 0 && dom.isAncestor(dom.getActiveElement(), widget.domNode)) {
+				await clipboardService.writeText(selectedText);
 				return;
 			}
 
-			const clipboardService = accessor.get(IClipboardService);
 			const text = stringifyItem(item, false);
-			clipboardService.writeText(text);
+			await clipboardService.writeText(text);
 		}
 	});
 }

src/vs/workbench/contrib/chat/common/chatViewModel.ts

@@ -30,6 +30,10 @@ export function isResponseVM(item: unknown): item is IChatResponseViewModel {
 	return !!item && typeof (item as IChatResponseViewModel).setVote !== 'undefined';
 }
 
+export function isChatTreeItem(item: unknown): item is IChatRequestViewModel | IChatResponseViewModel {
+	return isRequestVM(item) || isResponseVM(item);
+}
+
 export function assertIsResponseVM(item: unknown): asserts item is IChatResponseViewModel {
 	if (!isResponseVM(item)) {
 		throw new Error('Expected item to be IChatResponseViewModel');