Aux window: window.focus is broken (fix microsoft#196790) (microsoft#196791)

bpasero · web-flow · commit 2ff3e98d7747 · 2023-10-27T08:40:53.000+02:00
diff --git a/src/vs/workbench/services/auxiliaryWindow/electron-sandbox/auxiliaryWindowService.ts b/src/vs/workbench/services/auxiliaryWindow/electron-sandbox/auxiliaryWindowService.ts
@@ -71,7 +71,7 @@ export class NativeAuxiliaryWindowService extends BrowserAuxiliaryWindowService
 		auxiliaryWindow.focus = async function () {
 			originalWindowFocus();
 
-			if (getActiveWindow() === auxiliaryWindow) {
+			if (getActiveWindow() !== auxiliaryWindow) {
 				that.nativeHostService.focusWindow({ targetWindowId: await windowId.p });
 			}
 		};

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ export class NativeAuxiliaryWindowService extends BrowserAuxiliaryWindowService`
`71`	`71`	`auxiliaryWindow.focus = async function () {`
`72`	`72`	`originalWindowFocus();`
`73`	`73`
`74`		`- if (getActiveWindow() === auxiliaryWindow) {`
	`74`	`+ if (getActiveWindow() !== auxiliaryWindow) {`
`75`	`75`	`that.nativeHostService.focusWindow({ targetWindowId: await windowId.p });`
`76`	`76`	`}`
`77`	`77`	`};`