Fix microsoft#193468 - Fix bug with error notification when pressing "l" on non-expandable reference item. (microsoft#199996)

* Fix the bug that pressing l key on non-expandable reference item shows error notification (with vim extension)

* 💄

---------

Co-authored-by: João Moreno <[email protected]>

Author: audreygao

src/vs/base/browser/ui/tree/abstractTree.ts

@@ -2357,38 +2357,44 @@ export abstract class AbstractTree<T, TFilterData, TRef> implements IDisposable
 			return this.view.setAnchor(undefined);
 		}
 
-		const node = this.model.getNode(element);
-		this.anchor.set([node]);
+		this.eventBufferer.bufferEvents(() => {
+			const node = this.model.getNode(element);
+			this.anchor.set([node]);
 
-		const index = this.model.getListIndex(element);
+			const index = this.model.getListIndex(element);
 
-		if (index > -1) {
-			this.view.setAnchor(index, true);
-		}
+			if (index > -1) {
+				this.view.setAnchor(index, true);
+			}
+		});
 	}
 
 	getAnchor(): T | undefined {
 		return firstOrDefault(this.anchor.get(), undefined);
 	}
 
 	setSelection(elements: TRef[], browserEvent?: UIEvent): void {
-		const nodes = elements.map(e => this.model.getNode(e));
-		this.selection.set(nodes, browserEvent);
+		this.eventBufferer.bufferEvents(() => {
+			const nodes = elements.map(e => this.model.getNode(e));
+			this.selection.set(nodes, browserEvent);
 
-		const indexes = elements.map(e => this.model.getListIndex(e)).filter(i => i > -1);
-		this.view.setSelection(indexes, browserEvent, true);
+			const indexes = elements.map(e => this.model.getListIndex(e)).filter(i => i > -1);
+			this.view.setSelection(indexes, browserEvent, true);
+		});
 	}
 
 	getSelection(): T[] {
 		return this.selection.get();
 	}
 
 	setFocus(elements: TRef[], browserEvent?: UIEvent): void {
-		const nodes = elements.map(e => this.model.getNode(e));
-		this.focus.set(nodes, browserEvent);
+		this.eventBufferer.bufferEvents(() => {
+			const nodes = elements.map(e => this.model.getNode(e));
+			this.focus.set(nodes, browserEvent);
 
-		const indexes = elements.map(e => this.model.getListIndex(e)).filter(i => i > -1);
-		this.view.setFocus(indexes, browserEvent, true);
+			const indexes = elements.map(e => this.model.getListIndex(e)).filter(i => i > -1);
+			this.view.setFocus(indexes, browserEvent, true);
+		});
 	}
 
 	focusNext(n = 1, loop = false, browserEvent?: UIEvent, filter = (isKeyboardEvent(browserEvent) && browserEvent.altKey) ? undefined : this.focusNavigationFilter): void {

src/vs/workbench/browser/actions/listCommands.ts

@@ -488,8 +488,8 @@ function selectElement(accessor: ServicesAccessor, retainCurrentFocus: boolean):
 	// List
 	if (focused instanceof List || focused instanceof PagedList || focused instanceof Table) {
 		const list = focused;
-		list.setSelection(list.getFocus(), fakeKeyboardEvent);
 		list.setAnchor(list.getFocus()[0]);
+		list.setSelection(list.getFocus(), fakeKeyboardEvent);
 	}
 
 	// Trees
@@ -510,8 +510,8 @@ function selectElement(accessor: ServicesAccessor, retainCurrentFocus: boolean):
 				tree.toggleCollapsed(focus[0]);
 			}
 		}
-		tree.setSelection(focus, fakeKeyboardEvent);
 		tree.setAnchor(focus[0]);
+		tree.setSelection(focus, fakeKeyboardEvent);
 	}
 }