json edit: Ignore removes in a non existing node (microsoft#210025)

aeschli · web-flow · commit 3117776ea274 · 2024-04-10T10:12:12.000+02:00
diff --git a/src/vs/base/common/jsonEdit.ts b/src/vs/base/common/jsonEdit.ts
@@ -35,7 +35,7 @@ export function setProperty(text: string, originalPath: JSONPath, value: any, fo
 	if (!parent) {
 		// empty document
 		if (value === undefined) { // delete
-			throw new Error('Can not delete in empty document');
+			return []; // property does not exist, nothing to do
 		}
 		return withFormatting(text, { offset: root ? root.offset : 0, length: root ? root.length : 0, content: JSON.stringify(value) }, formattingOptions);
 	} else if (parent.type === 'object' && typeof lastSegment === 'string' && Array.isArray(parent.children)) {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export function setProperty(text: string, originalPath: JSONPath, value: any, fo`
`35`	`35`	`if (!parent) {`
`36`	`36`	`// empty document`
`37`	`37`	`if (value === undefined) { // delete`
`38`		`- throw new Error('Can not delete in empty document');`
	`38`	`+ return []; // property does not exist, nothing to do`
`39`	`39`	`}`
`40`	`40`	`return withFormatting(text, { offset: root ? root.offset : 0, length: root ? root.length : 0, content: JSON.stringify(value) }, formattingOptions);`
`41`	`41`	`} else if (parent.type === 'object' && typeof lastSegment === 'string' && Array.isArray(parent.children)) {`