inline chat tweaks (microsoft#201126)

* streamline tel data

* rename to LiveStrategy

* fix up highlights

Author: jrieken

src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts

@@ -42,7 +42,7 @@ import { IChatAgentService } from 'vs/workbench/contrib/chat/common/chatAgents';
 import { chatAgentLeader, chatSubcommandLeader } from 'vs/workbench/contrib/chat/common/chatParserTypes';
 import { IChatService } from 'vs/workbench/contrib/chat/common/chatService';
 import { EmptyResponse, ErrorResponse, ExpansionState, IInlineChatSessionService, ReplyResponse, Session, SessionExchange, SessionPrompt } from 'vs/workbench/contrib/inlineChat/browser/inlineChatSession';
-import { EditModeStrategy, LivePreviewStrategy, LiveStrategy3, PreviewStrategy, ProgressingEditsOptions } from 'vs/workbench/contrib/inlineChat/browser/inlineChatStrategies';
+import { EditModeStrategy, LivePreviewStrategy, LiveStrategy, PreviewStrategy, ProgressingEditsOptions } from 'vs/workbench/contrib/inlineChat/browser/inlineChatStrategies';
 import { IInlineChatMessageAppender, InlineChatZoneWidget } from 'vs/workbench/contrib/inlineChat/browser/inlineChatWidget';
 import { CTX_INLINE_CHAT_DID_EDIT, CTX_INLINE_CHAT_HAS_ACTIVE_REQUEST, CTX_INLINE_CHAT_HAS_STASHED_SESSION, CTX_INLINE_CHAT_LAST_FEEDBACK, CTX_INLINE_CHAT_RESPONSE_TYPES, CTX_INLINE_CHAT_SUPPORT_ISSUE_REPORTING, CTX_INLINE_CHAT_USER_DID_EDIT, EditMode, IInlineChatProgressItem, IInlineChatRequest, IInlineChatResponse, INLINE_CHAT_ID, InlineChatResponseFeedbackKind, InlineChatResponseTypes } from 'vs/workbench/contrib/inlineChat/common/inlineChat';
 
@@ -364,7 +364,7 @@ export class InlineChatController implements IEditorContribution {
 
 		switch (session.editMode) {
 			case EditMode.Live:
-				this._strategy = this._instaService.createInstance(LiveStrategy3, session, this._editor, this._zone.value);
+				this._strategy = this._instaService.createInstance(LiveStrategy, session, this._editor, this._zone.value);
 				break;
 			case EditMode.Preview:
 				this._strategy = this._instaService.createInstance(PreviewStrategy, session, this._zone.value);

src/vs/workbench/contrib/inlineChat/browser/inlineChatSession.ts

@@ -156,6 +156,7 @@ export class Session {
 			extension: provider.debugName,
 			startTime: this._startTime.toISOString(),
 			edits: false,
+			finishedByEdit: false,
 			rounds: '',
 			undos: '',
 			editMode

src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts

@@ -469,7 +469,7 @@ export function asProgressiveEdit(edit: IIdentifiedSingleEditOperation, wordsPer
 
 // ---
 
-export class LiveStrategy3 extends EditModeStrategy {
+export class LiveStrategy extends EditModeStrategy {
 
 	private readonly _decoModifiedInteractedWith = ModelDecorationOptions.register({
 		description: 'inline-chat-modified-interacted-with',
@@ -478,7 +478,7 @@ export class LiveStrategy3 extends EditModeStrategy {
 
 
 	private readonly _decoInsertedText = ModelDecorationOptions.register({
-		description: 'inline-modified',
+		description: 'inline-modified-line',
 		className: 'inline-chat-inserted-range-linehighlight',
 		isWholeLine: true,
 		overviewRuler: {
@@ -487,6 +487,11 @@ export class LiveStrategy3 extends EditModeStrategy {
 		}
 	});
 
+	private readonly _decoInsertedTextRange = ModelDecorationOptions.register({
+		description: 'inline-chat-inserted-range-linehighlight',
+		className: 'inline-chat-inserted-range',
+	});
+
 	private readonly _store: DisposableStore = new DisposableStore();
 	private readonly _sessionStore: DisposableStore = new DisposableStore();
 	private readonly _previewZone: Lazy<InlineChatFileCreatePreviewWidget>;
@@ -689,6 +694,12 @@ export class LiveStrategy3 extends EditModeStrategy {
 				options: this._decoInsertedText
 			});
 
+			for (const innerChange of innerChanges ?? []) {
+				newDecorations.push({
+					range: innerChange.modifiedRange,
+					options: this._decoInsertedTextRange
+				});
+			}
 
 			// original view zone
 			const source = new LineSource(