Skip to content

Commit 33a85fe

Browse files
authored
fix - overriding accessors properly (microsoft#255509)
1 parent 7b1c3d3 commit 33a85fe

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

src/vs/base/browser/ui/button/button.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -626,6 +626,10 @@ export class ButtonWithIcon extends Button {
626626
this._element.append(this._iconElement, this._mdlabelElement);
627627
}
628628

629+
override get label(): IMarkdownString | string {
630+
return super.label;
631+
}
632+
629633
override set label(value: IMarkdownString | string) {
630634
if (this._label === value) {
631635
return;
@@ -668,6 +672,10 @@ export class ButtonWithIcon extends Button {
668672
this._label = value;
669673
}
670674

675+
override get icon(): ThemeIcon {
676+
return super.icon;
677+
}
678+
671679
override set icon(icon: ThemeIcon) {
672680
this._iconElement.classList.value = '';
673681
this._iconElement.classList.add(...ThemeIcon.asClassNameArray(icon));

src/vs/platform/actions/browser/dropdownWithPrimaryActionViewItem.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
7575
this._dropdown.actionRunner = actionRunner;
7676
}
7777

78+
override get actionRunner(): IActionRunner {
79+
return super.actionRunner;
80+
}
81+
7882
override setActionContext(newContext: unknown): void {
7983
super.setActionContext(newContext);
8084
this._primaryAction.setActionContext(newContext);

0 commit comments

Comments
 (0)