debt - extract action ids into constants (microsoft#234079)

Author: jrieken

src/vs/workbench/contrib/chat/browser/chatEditorActions.ts

@@ -110,11 +110,9 @@ abstract class NavigateAction extends Action2 {
 
 abstract class AcceptDiscardAction extends Action2 {
 
-	constructor(readonly accept: boolean) {
+	constructor(id: string, readonly accept: boolean) {
 		super({
-			id: accept
-				? 'chatEditor.action.accept'
-				: 'chatEditor.action.reject',
+			id,
 			title: accept
 				? localize2('accept', 'Accept Chat Edit')
 				: localize2('discard', 'Discard Chat Edit'),
@@ -168,6 +166,24 @@ abstract class AcceptDiscardAction extends Action2 {
 	}
 }
 
+export class AcceptAction extends AcceptDiscardAction {
+
+	static readonly ID = 'chatEditor.action.accept';
+
+	constructor() {
+		super(AcceptAction.ID, true);
+	}
+}
+
+export class RejectAction extends AcceptDiscardAction {
+
+	static readonly ID = 'chatEditor.action.reject';
+
+	constructor() {
+		super(RejectAction.ID, false);
+	}
+}
+
 class UndoHunkAction extends EditorAction2 {
 	constructor() {
 		super({
@@ -218,8 +234,8 @@ class OpenDiffFromHunkAction extends EditorAction2 {
 export function registerChatEditorActions() {
 	registerAction2(class NextAction extends NavigateAction { constructor() { super(true); } });
 	registerAction2(class PrevAction extends NavigateAction { constructor() { super(false); } });
-	registerAction2(class AcceptAction extends AcceptDiscardAction { constructor() { super(true); } });
-	registerAction2(class RejectAction extends AcceptDiscardAction { constructor() { super(false); } });
+	registerAction2(AcceptAction);
+	registerAction2(RejectAction);
 	registerAction2(UndoHunkAction);
 	registerAction2(OpenDiffFromHunkAction);
 }

src/vs/workbench/contrib/chat/browser/chatEditorOverlay.ts

@@ -26,6 +26,7 @@ import { assertType } from '../../../../base/common/types.js';
 import { localize } from '../../../../nls.js';
 import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextkey.js';
 import { ctxNotebookHasEditorModification } from '../../notebook/browser/chatEdit/notebookChatEditController.js';
+import { AcceptAction, RejectAction } from './chatEditorActions.js';
 
 class ChatEditorOverlayWidget implements IOverlayWidget {
 
@@ -97,7 +98,7 @@ class ChatEditorOverlayWidget implements IOverlayWidget {
 					};
 				}
 
-				if (action.id === 'chatEditor.action.accept' || action.id === 'chatEditor.action.reject') {
+				if (action.id === AcceptAction.ID || action.id === RejectAction.ID) {
 					return new class extends ActionViewItem {
 
 						private readonly _reveal = this._store.add(new MutableDisposable());