Skip to content

Commit 3578399

Browse files
committed
Setup embedder terminal listener always
Part of microsoft#207372
1 parent 475b574 commit 3578399

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/vs/workbench/contrib/terminal/browser/terminalMainContribution.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,8 @@ export class TerminalMainContribution extends Disposable implements IWorkbenchCo
6161
terminalGroupService: ITerminalGroupService,
6262
terminalInstanceService: ITerminalInstanceService
6363
) {
64-
// Defer this for the local case only. This is important for the
65-
// window.createTerminal web embedder API to work before the workbench
66-
// is loaded on remote
67-
if (workbenchEnvironmentService.remoteAuthority === undefined) {
68-
await lifecycleService.when(LifecyclePhase.Restored);
69-
}
70-
64+
// IMPORTANT: This listener needs to be set up before the workbench is ready to support
65+
// embedder terminals.
7166
this._register(embedderTerminalService.onDidCreateTerminal(async embedderTerminal => {
7267
const terminal = await terminalService.createTerminal({
7368
config: embedderTerminal,

0 commit comments

Comments
 (0)