Skip to content

Commit 35b971c

Browse files
authored
use common task ID instead of map key (microsoft#159233)
* fix microsoft#158886 * Update src/vs/workbench/contrib/terminal/test/browser/links/terminalLocalLinkDetector.test.ts
1 parent 0a7b686 commit 35b971c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1287,7 +1287,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
12871287
for (let i = 0; i < this._reconnectedTerminals.length; i++) {
12881288
const terminal = this._reconnectedTerminals[i];
12891289
const taskForTerminal = terminal.shellLaunchConfig.attachPersistentProcess?.reconnectionProperties?.data as IReconnectionTaskData;
1290-
if (taskForTerminal.lastTask === task.getMapKey()) {
1290+
if (taskForTerminal.lastTask === task.getCommonTaskId()) {
12911291
this._reconnectedTerminals.splice(i, 1);
12921292
return terminal;
12931293
}
@@ -1455,7 +1455,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
14551455

14561456
this._terminalCreationQueue = this._terminalCreationQueue.then(() => this._doCreateTerminal(task, group, launchConfigs!));
14571457
const terminal: ITerminalInstance = (await this._terminalCreationQueue)!;
1458-
terminal.shellLaunchConfig.reconnectionProperties = { ownerId: ReconnectionType, data: { lastTask: taskKey, group, label: task._label, id: task._id } };
1458+
terminal.shellLaunchConfig.reconnectionProperties = { ownerId: ReconnectionType, data: { lastTask: task.getCommonTaskId(), group, label: task._label, id: task._id } };
14591459
const terminalKey = terminal.instanceId.toString();
14601460
const terminalData = { terminal: terminal, lastTask: taskKey, group };
14611461
terminal.onDisposed(() => this._deleteTaskAndTerminal(terminal, terminalData));

0 commit comments

Comments
 (0)