Skip to content

Commit 3640c5a

Browse files
authored
Merge pull request microsoft#187726 from microsoft/merogge/diff-review-help
don't alert w hint about moving to diff editor when verbosity is disabled
2 parents 4c0de39 + c451631 commit 3640c5a

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

src/vs/workbench/contrib/accessibility/browser/accessibilityContribution.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const configuration: IConfigurationNode = {
4444
...baseProperty
4545
},
4646
[AccessibilityVerbositySettingId.InlineChat]: {
47-
description: localize('verbosity.interactiveEditor.description', 'Provide information about how to access the inline editor chat accessibility help menu when the input is focused'),
47+
description: localize('verbosity.interactiveEditor.description', 'Provide information about how to access the inline editor chat accessibility help menu and alert with hints which describe how to use the feature when the input is focused'),
4848
...baseProperty
4949
},
5050
[AccessibilityVerbositySettingId.KeybindingsEditor]: {

src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ export class InlineChatController implements IEditorContribution {
655655
if (!canContinue) {
656656
return State.ACCEPT;
657657
}
658-
status = localize('editResponseMessage', "Use tab to navigate to the diff editor and review proposed changes.");
658+
status = this._configurationService.getValue('accessibility.verbosity.inlineChat') === true ? localize('editResponseMessage', "Use tab to navigate to the diff editor and review proposed changes.") : '';
659659
await this._strategy.renderChanges(response);
660660
}
661661
this._chatAccessibilityService.acceptResponse(status);

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ export class AccessibleBufferWidget extends TerminalAccessibleWidget {
7373
await this.updateEditor();
7474
this.element.classList.add(ClassName.Active);
7575
}));
76+
// xterm's initial layout call has already happened
77+
this.layout();
7678
}
7779

7880
navigateToCommand(type: NavigationType): void {

0 commit comments

Comments
 (0)