improve editor terminal menu

Author: meganrogge

src/vs/workbench/contrib/terminal/browser/terminalActions.ts

@@ -836,7 +836,7 @@ export function registerTerminalActions() {
 		constructor() {
 			super({
 				id: TerminalCommandId.Rename,
-				title: { value: localize('workbench.action.terminal.rename', "Rename..."), original: 'Rename...' },
+				title: terminalStrings.rename,
 				f1: true,
 				category,
 				precondition: KEYBINDING_CONTEXT_TERMINAL_PROCESS_SUPPORTED
@@ -850,7 +850,7 @@ export function registerTerminalActions() {
 		constructor() {
 			super({
 				id: TerminalCommandId.RenameInstance,
-				title: { value: localize('workbench.action.terminal.renameInstance', "Rename..."), original: 'Rename...' },
+				title: terminalStrings.rename,
 				f1: false,
 				category,
 				keybinding: {

src/vs/workbench/contrib/terminal/browser/terminalMenus.ts

@@ -532,11 +532,11 @@ export function setupTerminalMenus(): void {
 
 	MenuRegistry.appendMenuItem(MenuId.EditorTitleContext, {
 		command: {
-			id: TerminalCommandId.ChangeIcon,
-			title: terminalStrings.changeIcon
+			id: TerminalCommandId.Rename,
+			title: terminalStrings.rename
 		},
 		when: ResourceContextKey.Scheme.isEqualTo(Schemas.vscodeTerminal),
-		group: '2_files'
+		group: '3_files'
 	});
 
 	MenuRegistry.appendMenuItem(MenuId.EditorTitleContext, {
@@ -545,7 +545,16 @@ export function setupTerminalMenus(): void {
 			title: terminalStrings.changeColor
 		},
 		when: ResourceContextKey.Scheme.isEqualTo(Schemas.vscodeTerminal),
-		group: '2_files'
+		group: '3_files'
+	});
+
+	MenuRegistry.appendMenuItem(MenuId.EditorTitleContext, {
+		command: {
+			id: TerminalCommandId.ChangeIcon,
+			title: terminalStrings.changeIcon
+		},
+		when: ResourceContextKey.Scheme.isEqualTo(Schemas.vscodeTerminal),
+		group: '3_files'
 	});
 
 	MenuRegistry.appendMenuItem(MenuId.EditorTitle, {

src/vs/workbench/contrib/terminal/common/terminalStrings.ts

@@ -42,7 +42,7 @@ export const terminalStrings = {
 	},
 	changeColor: {
 		value: localize('workbench.action.terminal.changeColor', "Change Color..."),
-		original: 'Change Color'
+		original: 'Change Color...'
 	},
 	split: {
 		value: localize('splitTerminal', "Split Terminal"),
@@ -52,5 +52,10 @@ export const terminalStrings = {
 	unsplit: {
 		value: localize('unsplitTerminal', "Unsplit Terminal"),
 		original: 'Unsplit Terminal'
+	},
+	rename:
+	{
+		value: localize('workbench.action.terminal.rename', "Rename..."),
+		original: 'Rename...'
 	}
 };