Implements editor.inlineSuggest.experimental.triggerCommandOnProviderChange = true (microsoft#252986)

Author: hediet

src/vs/editor/common/config/editorOptions.ts

@@ -4341,6 +4341,11 @@ export interface IInlineSuggestOptions {
 		* @internal
 		*/
 		suppressInlineSuggestions?: string;
+
+		/**
+		* @internal
+		*/
+		triggerCommandOnProviderChange?: boolean;
 	};
 }
 
@@ -4374,6 +4379,7 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
 			},
 			experimental: {
 				suppressInlineSuggestions: '',
+				triggerCommandOnProviderChange: true,
 			},
 		};
 
@@ -4412,6 +4418,12 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
 					tags: ['experimental', 'onExp'],
 					description: nls.localize('inlineSuggest.suppressInlineSuggestions', "Suppresses inline completions for specified extension IDs -- comma separated.")
 				},
+				'editor.inlineSuggest.experimental.triggerCommandOnProviderChange': {
+					type: 'boolean',
+					default: defaults.experimental.triggerCommandOnProviderChange,
+					tags: ['experimental', 'onExp'],
+					description: nls.localize('inlineSuggest.triggerCommandOnProviderChange', "Controls whether to trigger a command when the inline suggestion provider changes.")
+				},
 				'editor.inlineSuggest.fontFamily': {
 					type: 'string',
 					default: defaults.fontFamily,
@@ -4466,6 +4478,7 @@ class InlineEditorSuggest extends BaseEditorOption<EditorOption.inlineSuggest, I
 			},
 			experimental: {
 				suppressInlineSuggestions: EditorStringOption.string(input.experimental?.suppressInlineSuggestions, this.defaultValue.experimental.suppressInlineSuggestions),
+				triggerCommandOnProviderChange: boolean(input.experimental?.triggerCommandOnProviderChange, this.defaultValue.experimental.triggerCommandOnProviderChange),
 			},
 		};
 	}

src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts

@@ -74,6 +74,7 @@ export class InlineCompletionsModel extends Disposable {
 	private readonly _suppressedInlineCompletionGroupIds;
 	private readonly _inlineEditsEnabled;
 	private readonly _inlineEditsShowCollapsedEnabled;
+	private readonly _triggerCommandOnProviderChange;
 
 	constructor(
 		public readonly textModel: ITextModel,
@@ -109,6 +110,8 @@ export class InlineCompletionsModel extends Disposable {
 		this._suppressedInlineCompletionGroupIds = this._editorObs.getOption(EditorOption.inlineSuggest).map(v => new Set(v.experimental.suppressInlineSuggestions.split(',')));
 		this._inlineEditsEnabled = this._editorObs.getOption(EditorOption.inlineSuggest).map(v => !!v.edits.enabled);
 		this._inlineEditsShowCollapsedEnabled = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.edits.showCollapsed);
+		this._triggerCommandOnProviderChange = this._editorObs.getOption(EditorOption.inlineSuggest).map(s => s.experimental.triggerCommandOnProviderChange);
+
 		this._lastShownInlineCompletionInfo = undefined;
 		this._lastAcceptedInlineCompletionInfo = undefined;
 		this._didUndoInlineEdits = derivedHandleChanges({
@@ -596,6 +599,19 @@ export class InlineCompletionsModel extends Disposable {
 					return;
 				}
 
+				// Only update the active editor
+				const activeEditor = this._codeEditorService.getFocusedCodeEditor() || this._codeEditorService.getActiveCodeEditor();
+				if (activeEditor !== this._editor) {
+					return;
+				}
+
+				if (this._triggerCommandOnProviderChange.get()) {
+					// TODO@hediet remove this and always do the else branch.
+					this.trigger(undefined, { onlyFetchInlineEdits: true });
+					return;
+				}
+
+
 				// If there is an active suggestion from a different provider, we ignore the update
 				const activeState = this.state.get();
 				if (activeState && (activeState.inlineCompletion || activeState.edits) && activeState.inlineCompletion?.source.provider !== provider) {