wait for extension activation in getChatSessionContributions() (microsoft#259126)

* wait for extension activation in getChatSessionContributions()

* fix promises

Author: joshspicer

src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

@@ -567,7 +567,7 @@ export function registerChatActions() {
 						// Use the new Promise-based API to get chat sessions
 						const cancellationToken = new CancellationTokenSource();
 						try {
-							const providers = chatSessionsService.getChatSessionContributions();
+							const providers = await chatSessionsService.getChatSessionContributions();
 							const providerNSessions: { providerType: string; session: IChatSessionItem }[] = [];
 
 							for (const provider of providers) {

src/vs/workbench/contrib/chat/browser/chatEditor.ts

@@ -130,7 +130,7 @@ export class ChatEditor extends EditorPane {
 		if (input.resource.scheme === Schemas.vscodeChatSession) {
 			const identifier = ChatSessionUri.parse(input.resource);
 			if (identifier) {
-				const contributions = this.chatSessionsService.getChatSessionContributions();
+				const contributions = await this.chatSessionsService.getChatSessionContributions([input.resource.authority]);
 				const contribution = contributions.find(c => c.type === identifier.chatSessionType);
 				if (contribution) {
 					this.widget.lockToCodingAgent(contribution.name, contribution.displayName);

src/vs/workbench/contrib/chat/browser/chatSessions.contribution.ts

@@ -295,7 +295,11 @@ export class ChatSessionsService extends Disposable implements IChatSessionsServ
 		return disposable;
 	}
 
-	getChatSessionContributions(): IChatSessionsExtensionPoint[] {
+	async getChatSessionContributions(waitForActivation?: string[]): Promise<IChatSessionsExtensionPoint[]> {
+		await this._extensionService.whenInstalledExtensionsRegistered();
+		if (waitForActivation) {
+			await Promise.all(waitForActivation.map(id => this._extensionService.activateByEvent(`onChatSession:${id}`)));
+		}
 		return Array.from(this._contributions.values()).filter(contribution =>
 			this._isContributionAvailable(contribution)
 		);

src/vs/workbench/contrib/chat/browser/chatSessions.ts

@@ -715,16 +715,16 @@ class SessionsViewPane extends ViewPane {
 		}
 	}
 
-	private getProviderDisplayName(): string {
-		const contributions = this.chatSessionsService.getChatSessionContributions();
+	private async getProviderDisplayName(): Promise<string> {
+		const contributions = await this.chatSessionsService.getChatSessionContributions();
 		const contribution = contributions.find(c => c.type === this.provider.chatSessionType);
 		if (contribution) {
 			return contribution.displayName;
 		}
 		return '';
 	}
 
-	private showEmptyMessage(): void {
+	private async showEmptyMessage(): Promise<void> {
 		if (!this.messageElement) {
 			return;
 		}
@@ -735,7 +735,7 @@ class SessionsViewPane extends ViewPane {
 			return;
 		}
 
-		const providerName = this.getProviderDisplayName();
+		const providerName = await this.getProviderDisplayName();
 		if (!providerName) {
 			return;
 		}
@@ -775,15 +775,15 @@ class SessionsViewPane extends ViewPane {
 	 * Updates the empty state message based on current tree data.
 	 * Uses the tree's existing data to avoid redundant provider calls.
 	 */
-	private updateEmptyStateMessage(): void {
+	private async updateEmptyStateMessage(): Promise<void> {
 		try {
 			// Check if the tree has the provider node and get its children count
 			if (this.tree?.hasNode(this.provider)) {
 				const providerNode = this.tree.getNode(this.provider);
 				const childCount = providerNode.children?.length || 0;
 
 				if (childCount === 0) {
-					this.showEmptyMessage();
+					await this.showEmptyMessage();
 				} else {
 					this.hideMessage();
 				}
@@ -814,7 +814,7 @@ class SessionsViewPane extends ViewPane {
 			);
 
 			// Check for empty state after refresh using tree data
-			this.updateEmptyStateMessage();
+			await this.updateEmptyStateMessage();
 		} catch (error) {
 			// Log error but don't throw to avoid breaking the UI
 			this.logService.error('Error refreshing chat sessions tree:', error);
@@ -842,7 +842,7 @@ class SessionsViewPane extends ViewPane {
 			);
 
 			// Check for empty state after loading using tree data
-			this.updateEmptyStateMessage();
+			await this.updateEmptyStateMessage();
 		} catch (error) {
 			// Log error but don't throw to avoid breaking the UI
 			this.logService.error('Error loading chat sessions data:', error);

src/vs/workbench/contrib/chat/common/chatSessionsService.ts

@@ -68,7 +68,7 @@ export interface IChatSessionsService {
 	readonly onDidChangeSessionItems: Event<string>;
 	readonly onDidChangeAvailability: Event<void>;
 	registerContribution(contribution: IChatSessionsExtensionPoint): IDisposable;
-	getChatSessionContributions(): IChatSessionsExtensionPoint[];
+	getChatSessionContributions(waitForActivation?: string[]): Promise<IChatSessionsExtensionPoint[]>;
 	canResolveItemProvider(chatSessionType: string): Promise<boolean>;
 	canResolveContentProvider(chatSessionType: string): Promise<boolean>;
 	getChatSessionItemProviders(): IChatSessionItemProvider[];