Skip to content

Commit 3a4c2b1

Browse files
author
Kartik Raj
committed
Comment out the proposal to fix compile errors
1 parent 0185d27 commit 3a4c2b1

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

src/vs/workbench/api/common/extHostExtensionService.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,10 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
522522
checkProposedApiEnabled(extensionDescription, 'extensionRuntime');
523523
return that.extensionRuntime;
524524
},
525-
get environmentVariableCollection() { return that._extHostTerminalService.getEnvironmentVariableCollection(extensionDescription); },
525+
get environmentVariableCollection() {
526+
// TODO: Remove `as` cast once workspace collection proposal is finalized.
527+
return (that._extHostTerminalService.getEnvironmentVariableCollection(extensionDescription) as vscode.EnvironmentVariableCollection);
528+
},
526529
get messagePassingProtocol() {
527530
if (!messagePassingProtocol) {
528531
if (!messagePort) {

src/vscode-dts/vscode.proposed.envCollectionWorkspace.d.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ declare module 'vscode' {
77

88
// https://github.com/microsoft/vscode/issues/182069
99

10-
export interface ExtensionContext {
11-
/**
12-
* Gets the extension's environment variable collection for this workspace, enabling changes
13-
* to be applied to terminal environment variables.
14-
*
15-
* @param scope The scope to which the environment variable collection applies to.
16-
*/
17-
readonly environmentVariableCollection: EnvironmentVariableCollection | { getScopedEnvironmentVariableCollection(scope: EnvironmentVariableScope): EnvironmentVariableCollection };
18-
}
10+
// export interface ExtensionContext {
11+
// /**
12+
// * Gets the extension's environment variable collection for this workspace, enabling changes
13+
// * to be applied to terminal environment variables.
14+
// *
15+
// * @param scope The scope to which the environment variable collection applies to.
16+
// */
17+
// readonly environmentVariableCollection: EnvironmentVariableCollection | { getScopedEnvironmentVariableCollection(scope: EnvironmentVariableScope): EnvironmentVariableCollection };
18+
// }
1919

2020
export type EnvironmentVariableScope = {
2121
/**

0 commit comments

Comments
 (0)