Merge pull request microsoft#146213 from microsoft/rebornix/update-replace-all-nb

rebornix · web-flow · commit 3a5a1690e2d0 · 2022-03-28T15:30:21.000-07:00
fix microsoft#142756 update replace all button after input is updated
diff --git a/src/vs/workbench/contrib/notebook/browser/contrib/find/findController.ts b/src/vs/workbench/contrib/notebook/browser/contrib/find/findController.ts
@@ -88,7 +88,7 @@ export class NotebookFindWidget extends SimpleFindReplaceWidget implements INote
 			}
 
 			const matches = this._findModel.findMatches;
-			this._replaceAllBtn.setEnabled(matches.find(match => match.modelMatchCount < match.matches.length) === null);
+			this._replaceAllBtn.setEnabled(matches.length > 0 && matches.find(match => match.modelMatchCount < match.matches.length) === undefined);
 
 			if (e.filters) {
 				this._findInput.updateFilterState((this._state.filters?.markupPreview ?? false) || (this._state.filters?.codeOutput ?? false));

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ export class NotebookFindWidget extends SimpleFindReplaceWidget implements INote`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`const matches = this._findModel.findMatches;`
`91`		`- this._replaceAllBtn.setEnabled(matches.find(match => match.modelMatchCount < match.matches.length) === null);`
	`91`	`+ this._replaceAllBtn.setEnabled(matches.length > 0 && matches.find(match => match.modelMatchCount < match.matches.length) === undefined);`
`92`	`92`
`93`	`93`	`if (e.filters) {`
`94`	`94`	`this._findInput.updateFilterState((this._state.filters?.markupPreview ?? false) \|\| (this._state.filters?.codeOutput ?? false));`