testing: remove back compat shims for coverage API (microsoft#209559)

Now that the API is finalized, remove the back compat shims that were in place

Author: connor4312

src/vs/workbench/api/common/extHost.api.impl.ts

@@ -1666,7 +1666,6 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
 			StatementCoverage: extHostTypes.StatementCoverage,
 			BranchCoverage: extHostTypes.BranchCoverage,
 			DeclarationCoverage: extHostTypes.DeclarationCoverage,
-			FunctionCoverage: extHostTypes.DeclarationCoverage,  // back compat for Feb 2024
 			WorkspaceTrustState: extHostTypes.WorkspaceTrustState,
 			LanguageStatusSeverity: extHostTypes.LanguageStatusSeverity,
 			QuickPickItemKind: extHostTypes.QuickPickItemKind,

src/vs/workbench/api/common/extHostTesting.ts

@@ -434,10 +434,7 @@ class TestRunTracker extends Disposable {
 	private readonly cts: CancellationTokenSource;
 	private readonly endEmitter = this._register(new Emitter<void>());
 	private readonly onDidDispose: Event<void>;
-	private readonly publishedCoverage = new Map<string, {
-		coverage: vscode.FileCoverage;
-		backCompatResolve?: (token: vscode.CancellationToken) => Thenable<vscode.FileCoverageDetail[]>;
-	}>();
+	private readonly publishedCoverage = new Map<string, vscode.FileCoverage>();
 
 	/**
 	 * Fires when a test ends, and no more tests are left running.
@@ -492,21 +489,17 @@ class TestRunTracker extends Disposable {
 	/** Gets details for a previously-emitted coverage object. */
 	public getCoverageDetails(id: string, token: CancellationToken) {
 		const [, taskId, covId] = TestId.fromString(id).path; /** runId, taskId, URI */
-		const obj = this.publishedCoverage.get(covId);
-		if (!obj) {
+		const coverage = this.publishedCoverage.get(covId);
+		if (!coverage) {
 			return [];
 		}
 
-		if (obj.backCompatResolve) {
-			return obj.backCompatResolve(token);
-		}
-
 		const task = this.tasks.get(taskId);
 		if (!task) {
 			throw new Error('unreachable: run task was not found');
 		}
 
-		return this.profile?.loadDetailedCoverage?.(task.run, obj.coverage, token) ?? [];
+		return this.profile?.loadDetailedCoverage?.(task.run, coverage, token) ?? [];
 	}
 
 	/** Creates the public test run interface to give to extensions. */
@@ -545,42 +538,18 @@ class TestRunTracker extends Disposable {
 			this.proxy.$appendTestMessagesInRun(runId, taskId, TestId.fromExtHostTestItem(test, ctrlId).toString(), converted);
 		};
 
-		const addCoverage = (coverage: vscode.FileCoverage, backCompatResolve?: (token: vscode.CancellationToken) => Thenable<vscode.FileCoverageDetail[]>) => {
-			const uriStr = coverage.uri.toString();
-			const id = new TestId([runId, taskId, uriStr]).toString();
-			this.publishedCoverage.set(uriStr, { coverage, backCompatResolve });
-			this.proxy.$appendCoverage(runId, taskId, Convert.TestCoverage.fromFile(id, coverage));
-		};
-
-		interface ICoverageProvider {
-			provideFileCoverage(token: CancellationToken): vscode.ProviderResult<vscode.FileCoverage[]>;
-			resolveFileCoverage?(coverage: vscode.FileCoverage, token: CancellationToken): vscode.ProviderResult<vscode.FileCoverage>;
-		}
-
 		let ended = false;
-		let coverageProvider: ICoverageProvider | undefined;
-		const run: vscode.TestRun & { coverageProvider?: ICoverageProvider } = {
+		const run: vscode.TestRun = {
 			isPersisted: this.dto.isPersisted,
 			token: this.cts.token,
 			name,
 			onDidDispose: this.onDidDispose,
-			// todo@connor4312: back compat
-			get coverageProvider() {
-				return coverageProvider;
-			},
-			// todo@connor4312: back compat
-			set coverageProvider(provider: ICoverageProvider | undefined) {
-				coverageProvider = provider;
-				if (provider) {
-					Promise.resolve(provider.provideFileCoverage(CancellationToken.None)).then(coverage => {
-						coverage?.forEach(c => addCoverage(c, provider.resolveFileCoverage && (async token => {
-							const r = await provider.resolveFileCoverage!(c, token);
-							return (r || c as any).detailedCoverage;
-						})));
-					});
-				}
+			addCoverage: coverage => {
+				const uriStr = coverage.uri.toString();
+				const id = new TestId([runId, taskId, uriStr]).toString();
+				this.publishedCoverage.set(uriStr, coverage);
+				this.proxy.$appendCoverage(runId, taskId, Convert.TestCoverage.fromFile(id, coverage));
 			},
-			addCoverage,
 			//#region state mutation
 			enqueued: guardTestMutation(test => {
 				this.proxy.$updateTestStateInRun(runId, taskId, TestId.fromExtHostTestItem(test, ctrlId).toString(), TestResultState.Queued);