Merge pull request microsoft#191912 from microsoft/merogge/windows-command-start

meganrogge · web-flow · commit 3cd6f481266d · 2023-08-31T09:44:37.000-07:00
fix undefined check, get textarea sync to work for windows
diff --git a/src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts b/src/vs/workbench/contrib/terminalContrib/accessibility/browser/textAreaSyncAddon.ts
@@ -100,7 +100,7 @@ export class TextAreaSyncAddon extends Disposable implements ITerminalAddon {
 			this._logService.debug(`TextAreaSyncAddon#updateCommandAndCursor: no line`);
 			return;
 		}
-		if (!!currentCommand.commandStartX) {
+		if (currentCommand.commandStartX !== undefined) {
 			this._currentCommand = commandLine.substring(currentCommand.commandStartX);
 			this._cursorX = buffer.cursorX - currentCommand.commandStartX;
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ export class TextAreaSyncAddon extends Disposable implements ITerminalAddon {`
`100`	`100`	this._logService.debug(`TextAreaSyncAddon#updateCommandAndCursor: no line`);
`101`	`101`	`return;`
`102`	`102`	`}`
`103`		`- if (!!currentCommand.commandStartX) {`
	`103`	`+ if (currentCommand.commandStartX !== undefined) {`
`104`	`104`	`this._currentCommand = commandLine.substring(currentCommand.commandStartX);`
`105`	`105`	`this._cursorX = buffer.cursorX - currentCommand.commandStartX;`
`106`	`106`	`} else {`