Skip to content

Commit 3cf6788

Browse files
authored
Re microsoft#229883. Event emitter and version increment should be sync'ed (microsoft#229900)
* Fix microsoft#229883. content event is required for cell content change. * Re microsoft#229883. Event emitter and version increment should be sync'ed
1 parent 64e959c commit 3cf6788

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ export class NotebookTextModel extends Disposable implements INotebookTextModel
330330
}
331331

332332
private _bindCellContentHandler(cell: NotebookCellTextModel, e: 'content' | 'language' | 'mime' | { type: 'model'; event: IModelContentChangedEvent }) {
333-
this._increaseVersionId(e === 'content');
333+
this._increaseVersionId(e === 'content' || (typeof e === 'object' && e.type === 'model'));
334334
switch (e) {
335335
case 'content':
336336
this._pauseableEmitter.fire({
@@ -358,6 +358,17 @@ export class NotebookTextModel extends Disposable implements INotebookTextModel
358358
endSelectionState: undefined
359359
});
360360
break;
361+
362+
default:
363+
if (typeof e === 'object' && e.type === 'model') {
364+
this._pauseableEmitter.fire({
365+
rawEvents: [{ kind: NotebookCellsChangeType.ChangeCellContent, index: this._getCellIndexByHandle(cell.handle), transient: false }],
366+
versionId: this.versionId,
367+
synchronous: true,
368+
endSelectionState: undefined
369+
});
370+
}
371+
break;
361372
}
362373
}
363374

0 commit comments

Comments
 (0)