add opt-in setting for new task tools (microsoft#257178)

Author: meganrogge

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/task.chatAgentTools.contribution.ts

@@ -8,6 +8,7 @@ import { IConfigurationService } from '../../../../../platform/configuration/com
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
 import { registerWorkbenchContribution2, WorkbenchPhase, type IWorkbenchContribution } from '../../../../common/contributions.js';
 import { ILanguageModelToolsService } from '../../../chat/common/languageModelToolsService.js';
+import { TerminalChatAgentToolsSettingId } from '../common/terminalChatAgentToolsConfiguration.js';
 import { GetTaskOutputTool, GetTaskOutputToolData } from './task/getTaskOutputTool.js';
 import { RunTaskTool, RunTaskToolData } from './task/runTaskTool.js';
 
@@ -23,14 +24,15 @@ class ChatAgentToolsContribution extends Disposable implements IWorkbenchContrib
 		@ILanguageModelToolsService toolsService: ILanguageModelToolsService,
 	) {
 		super();
-
-		const runTaskTool = instantiationService.createInstance(RunTaskTool);
-		this._register(toolsService.registerToolData(RunTaskToolData));
-		this._register(toolsService.registerToolImplementation(RunTaskToolData.id, runTaskTool));
-
-		const getTaskOutputTool = instantiationService.createInstance(GetTaskOutputTool);
-		this._register(toolsService.registerToolData(GetTaskOutputToolData));
-		this._register(toolsService.registerToolImplementation(GetTaskOutputToolData.id, getTaskOutputTool));
+		if (configurationService.getValue(TerminalChatAgentToolsSettingId.NewTaskToolsEnabled)) {
+			const runTaskTool = instantiationService.createInstance(RunTaskTool);
+			this._register(toolsService.registerToolData(RunTaskToolData));
+			this._register(toolsService.registerToolImplementation(RunTaskToolData.id, runTaskTool));
+
+			const getTaskOutputTool = instantiationService.createInstance(GetTaskOutputTool);
+			this._register(toolsService.registerToolData(GetTaskOutputToolData));
+			this._register(toolsService.registerToolImplementation(GetTaskOutputToolData.id, getTaskOutputTool));
+		}
 	}
 }
 registerWorkbenchContribution2(ChatAgentToolsContribution.ID, ChatAgentToolsContribution, WorkbenchPhase.AfterRestored);

src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/terminal.chatAgentTools.contribution.ts

@@ -7,7 +7,6 @@ import { Codicon } from '../../../../../base/common/codicons.js';
 import { Disposable } from '../../../../../base/common/lifecycle.js';
 import { ThemeIcon } from '../../../../../base/common/themables.js';
 import { localize } from '../../../../../nls.js';
-import { IConfigurationService } from '../../../../../platform/configuration/common/configuration.js';
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
 import { registerWorkbenchContribution2, WorkbenchPhase, type IWorkbenchContribution } from '../../../../common/contributions.js';
 import { ILanguageModelToolsService, ToolDataSource } from '../../../chat/common/languageModelToolsService.js';
@@ -21,12 +20,10 @@ class ChatAgentToolsContribution extends Disposable implements IWorkbenchContrib
 	static readonly ID = 'terminal.chatAgentTools';
 
 	constructor(
-		@IConfigurationService configurationService: IConfigurationService,
 		@IInstantiationService instantiationService: IInstantiationService,
 		@ILanguageModelToolsService toolsService: ILanguageModelToolsService,
 	) {
 		super();
-
 		const runInTerminalTool = instantiationService.createInstance(RunInTerminalTool);
 		this._register(toolsService.registerToolData(RunInTerminalToolData));
 		this._register(toolsService.registerToolImplementation(RunInTerminalToolData.id, runInTerminalTool));

src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts

@@ -10,10 +10,12 @@ import { ConfigurationScope, type IConfigurationPropertySchema } from '../../../
 
 export const enum TerminalChatAgentToolsSettingId {
 	AutoApprove = 'chat.agent.terminal.autoApprove',
+	NewTaskToolsEnabled = 'chat.agent.terminal.newTaskToolsEnabled',
 }
 
 export interface ITerminalChatAgentToolsConfiguration {
 	autoApprove: { [key: string]: boolean };
+	newTaskToolsEnabled: boolean;
 }
 
 const autoApproveBoolean: IJSONSchema = {
@@ -30,6 +32,11 @@ const autoApproveBoolean: IJSONSchema = {
 };
 
 export const terminalChatAgentToolsConfiguration: IStringDictionary<IConfigurationPropertySchema> = {
+	[TerminalChatAgentToolsSettingId.NewTaskToolsEnabled]: {
+		markdownDescription: localize('newTaskToolsEnabled.description', "Whether the new task tools are enabled."),
+		type: 'boolean',
+		default: false
+	},
 	[TerminalChatAgentToolsSettingId.AutoApprove]: {
 		markdownDescription: [
 			localize('autoApprove.description.intro', "A list of commands or regular expressions that control whether the run in terminal tool commands require explicit approval. These will be matched against the start of a command. A regular expression can be provided by wrapping the string in {0} characters followed by optional flags such as {1} for case-insensitivity.", '`/`', '`i`'),