Skip to content

Commit 3df0be6

Browse files
Fix notebook inline values when using language provider (microsoft#254264)
It seems microsoft#240731 broke inline values from language providers by only updating decorations from the fallback code. Co-authored-by: Michael Lively <[email protected]>
1 parent bdae787 commit 3df0be6

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookInlineVariables.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ export class NotebookInlineVariablesController extends Disposable implements INo
244244
return;
245245
}
246246

247-
const inlineDecorations: IModelDeltaDecoration[] = [];
248247
const processedVars = new Set<string>();
249248

250249
// Get both function ranges and comment ranges
@@ -323,11 +322,11 @@ export class NotebookInlineVariablesController extends Disposable implements INo
323322
}
324323
}
325324
});
325+
}
326326

327-
if (inlineDecorations.length > 0) {
328-
this.updateCellInlineDecorations(cell, inlineDecorations);
329-
this.initCellContentListener(cell);
330-
}
327+
if (inlineDecorations.length > 0) {
328+
this.updateCellInlineDecorations(cell, inlineDecorations);
329+
this.initCellContentListener(cell);
331330
}
332331
}
333332

0 commit comments

Comments
 (0)