Fix custom hover closing context view for breadcrumbs (microsoft#205518)

Fix custom hover closes context view for breadcrumbs

Author: benibenj

src/vs/base/browser/ui/iconLabel/iconHoverDelegate.ts

@@ -62,6 +62,7 @@ export interface IHoverDelegate {
 	onDidHideHover?: () => void;
 	delay: number;
 	placement?: 'mouse' | 'element';
+	showNativeHover?: boolean; // TODO@benibenj remove this, only temp fix for contextviews
 }
 
 export interface IScopedHoverDelegate extends IHoverDelegate, IDisposable { }

src/vs/base/browser/ui/iconLabel/iconLabel.ts

@@ -7,7 +7,7 @@ import 'vs/css!./iconlabel';
 import * as dom from 'vs/base/browser/dom';
 import { HighlightedLabel } from 'vs/base/browser/ui/highlightedlabel/highlightedLabel';
 import { IHoverDelegate } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate';
-import { ITooltipMarkdownString, setupCustomHover } from 'vs/base/browser/ui/iconLabel/iconLabelHover';
+import { ITooltipMarkdownString, setupCustomHover, setupNativeHover } from 'vs/base/browser/ui/iconLabel/iconLabelHover';
 import { IMatch } from 'vs/base/common/filters';
 import { Disposable, IDisposable } from 'vs/base/common/lifecycle';
 import { equals } from 'vs/base/common/objects';
@@ -187,9 +187,13 @@ export class IconLabel extends Disposable {
 			return;
 		}
 
-		const hoverDisposable = setupCustomHover(this.hoverDelegate, htmlElement, tooltip);
-		if (hoverDisposable) {
-			this.customHovers.set(htmlElement, hoverDisposable);
+		if (this.hoverDelegate.showNativeHover) {
+			setupNativeHover(htmlElement, tooltip);
+		} else {
+			const hoverDisposable = setupCustomHover(this.hoverDelegate, htmlElement, tooltip);
+			if (hoverDisposable) {
+				this.customHovers.set(htmlElement, hoverDisposable);
+			}
 		}
 	}
 

src/vs/platform/hover/browser/hover.ts

@@ -283,3 +283,12 @@ export class WorkbenchHoverDelegate extends Disposable implements IHoverDelegate
 		}
 	}
 }
+
+// TODO@benibenj remove this, only temp fix for contextviews
+export const nativeHoverDelegate: IHoverDelegate = {
+	showHover: function (): IHoverWidget | undefined {
+		throw new Error('Native hover function not implemented.');
+	},
+	delay: 0,
+	showNativeHover: true
+};

src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts

@@ -41,7 +41,7 @@ import { Codicon } from 'vs/base/common/codicons';
 import { defaultBreadcrumbsWidgetStyles } from 'vs/platform/theme/browser/defaultStyles';
 import { Emitter } from 'vs/base/common/event';
 import { IHoverDelegate } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate';
-import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegate';
+import { nativeHoverDelegate } from 'vs/platform/hover/browser/hover';
 
 class OutlineItem extends BreadcrumbsItem {
 
@@ -230,7 +230,7 @@ export class BreadcrumbsControl {
 		this._ckBreadcrumbsVisible = BreadcrumbsControl.CK_BreadcrumbsVisible.bindTo(this._contextKeyService);
 		this._ckBreadcrumbsActive = BreadcrumbsControl.CK_BreadcrumbsActive.bindTo(this._contextKeyService);
 
-		this._hoverDelegate = getDefaultHoverDelegate('mouse');
+		this._hoverDelegate = nativeHoverDelegate;
 
 		this._disposables.add(breadcrumbsService.register(this._editorGroup.id, this._widget));
 		this.hide();

src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts

@@ -31,6 +31,8 @@ import { IOutline, IOutlineComparator } from 'vs/workbench/services/outline/brow
 import { IEditorOptions } from 'vs/platform/editor/common/editor';
 import { IEditorService, SIDE_GROUP } from 'vs/workbench/services/editor/common/editorService';
 import { ITextResourceConfigurationService } from 'vs/editor/common/services/textResourceConfiguration';
+import { IHoverDelegate } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate';
+import { nativeHoverDelegate } from 'vs/platform/hover/browser/hover';
 
 interface ILayoutInfo {
 	maxHeight: number;
@@ -213,12 +215,13 @@ class FileRenderer implements ITreeRenderer<IFileStat | IWorkspaceFolder, FuzzyS
 
 	constructor(
 		private readonly _labels: ResourceLabels,
+		private readonly _hoverDelegate: IHoverDelegate,
 		@IConfigurationService private readonly _configService: IConfigurationService,
 	) { }
 
 
 	renderTemplate(container: HTMLElement): IResourceLabel {
-		return this._labels.create(container, { supportHighlights: true });
+		return this._labels.create(container, { supportHighlights: true, hoverDelegate: this._hoverDelegate });
 	}
 
 	renderElement(node: ITreeNode<IWorkspaceFolder | IFileStat, [number, number, number]>, index: number, templateData: IResourceLabel): void {
@@ -374,7 +377,7 @@ export class BreadcrumbsFilePicker extends BreadcrumbsPicker {
 			'BreadcrumbsFilePicker',
 			container,
 			new FileVirtualDelegate(),
-			[this._instantiationService.createInstance(FileRenderer, labels)],
+			[this._instantiationService.createInstance(FileRenderer, labels, nativeHoverDelegate)],
 			this._instantiationService.createInstance(FileDataSource),
 			{
 				multipleSelectionSupport: false,

src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsTree.ts

@@ -26,6 +26,7 @@ import { ThemeIcon } from 'vs/base/common/themables';
 import { mainWindow } from 'vs/base/browser/window';
 import { IHoverDelegate } from 'vs/base/browser/ui/iconLabel/iconHoverDelegate';
 import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegate';
+import { nativeHoverDelegate } from 'vs/platform/hover/browser/hover';
 
 export type DocumentSymbolItem = OutlineGroup | OutlineElement;
 
@@ -125,7 +126,7 @@ export class DocumentSymbolRenderer implements ITreeRenderer<OutlineElement, Fuz
 		@IConfigurationService private readonly _configurationService: IConfigurationService,
 		@IThemeService private readonly _themeService: IThemeService,
 	) {
-		this._hoverDelegate = getDefaultHoverDelegate(target === OutlineTarget.Breadcrumbs ? 'element' : 'mouse');
+		this._hoverDelegate = target === OutlineTarget.OutlinePane ? getDefaultHoverDelegate('mouse') : nativeHoverDelegate;
 	}
 
 	renderTemplate(container: HTMLElement): DocumentSymbolTemplate {