Skip to content

Commit 400369e

Browse files
authored
Testing tunneling: Wording in connection toast (microsoft#178088)
1 parent a0ed4eb commit 400369e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/vs/platform/remoteTunnel/node/remoteTunnelService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export class RemoteTunnelService extends Disposable implements IRemoteTunnelServ
174174

175175
const hostName = this._getHostName();
176176
if (hostName) {
177-
this.setTunnelStatus(TunnelStates.connecting(localize({ key: 'remoteTunnelService.openTunnelWithName', comment: ['{0} is a host name'] }, 'Opening tunnel for {0}', hostName)));
177+
this.setTunnelStatus(TunnelStates.connecting(localize({ key: 'remoteTunnelService.openTunnelWithName', comment: ['{0} is a tunnel name'] }, 'Opening tunnel {0}', hostName)));
178178
} else {
179179
this.setTunnelStatus(TunnelStates.connecting(localize('remoteTunnelService.openTunnel', 'Opening tunnel')));
180180
}

src/vs/workbench/contrib/remoteTunnel/electron-sandbox/remoteTunnel.contribution.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ namespace RemoteTunnelCommandLabels {
8080
export const showLog = localize('remoteTunnel.actions.showLog', 'Show Remote Tunnel Service Log');
8181
export const configure = localize('remoteTunnel.actions.configure', 'Configure Machine Name...');
8282
export const copyToClipboard = localize('remoteTunnel.actions.copyToClipboard', 'Copy Browser URI to Clipboard');
83-
export const learnMore = localize('remoteTunnel.actions.learnMore', 'Get Started with VS Code Tunnels');
83+
export const learnMore = localize('remoteTunnel.actions.learnMore', 'Get Started with Tunnels');
8484
}
8585

8686

@@ -215,9 +215,9 @@ export class RemoteTunnelWorkbenchContribution extends Disposable implements IWo
215215
localize(
216216
{
217217
key: 'recommend.remoteExtension',
218-
comment: ['{0} will be a host name, {1} will the link address to the web UI, {6} an extension name. [label](command:commandId) is a markdown link. Only translate the label, do not modify the format']
218+
comment: ['{0} will be a tunnel name, {1} will the link address to the web UI, {6} an extension name. [label](command:commandId) is a markdown link. Only translate the label, do not modify the format']
219219
},
220-
"'{0}' has turned on remote access. The {1} extension can be used to connect to it.",
220+
"Tunnel '{0}' is avaiable for remote access. The {1} extension can be used to connect to it.",
221221
usedOnHost, remoteExtension.friendlyName
222222
),
223223
actions: {
@@ -529,10 +529,10 @@ export class RemoteTunnelWorkbenchContribution extends Disposable implements IWo
529529
localize(
530530
{
531531
key: 'progress.turnOn.final',
532-
comment: ['{0} will be a host name, {1} will the link address to the web UI, {6} an extesnion name. [label](command:commandId) is a markdown link. Only translate the label, do not modify the format']
532+
comment: ['{0} will be the tunnel name, {1} will the link address to the web UI, {6} an extension name, {7} a link to the extension documentation. [label](command:commandId) is a markdown link. Only translate the label, do not modify the format']
533533
},
534-
"Remote tunnel access is enabled for [{0}](command:{4}). To access from a different machine, open [{1}]({2}) or use the {6} extension. Use the Account menu to [configure](command:{3}) or [turn off](command:{5}).",
535-
connectionInfo.hostName, connectionInfo.domain, linkToOpenForMarkdown, RemoteTunnelCommandIds.manage, RemoteTunnelCommandIds.configure, RemoteTunnelCommandIds.turnOff, remoteExtension.friendlyName
534+
"You can now access this machine anywhere via the secure tunnel [{0}](command:{4}). To connect via a different machine, use the generated [{1}]({2}) link or use the [{6}]({7}) extension in the desktop or web. You can [configure](command:{3}) or [turn off](command:{5}) this access via the VS Code Accounts menu.",
535+
connectionInfo.hostName, connectionInfo.domain, linkToOpenForMarkdown, RemoteTunnelCommandIds.manage, RemoteTunnelCommandIds.configure, RemoteTunnelCommandIds.turnOff, remoteExtension.friendlyName, 'https://code.visualstudio.com/docs/remote/tunnels'
536536
),
537537
actions: {
538538
primary: [
@@ -729,7 +729,7 @@ export class RemoteTunnelWorkbenchContribution extends Disposable implements IWo
729729
items.push({ id: RemoteTunnelCommandIds.learnMore, label: RemoteTunnelCommandLabels.learnMore });
730730
if (this.connectionInfo && account) {
731731
quickPick.title = localize(
732-
{ key: 'manage.title.on', comment: ['{0} will be a user account name, {1} the provider name (e.g. Github), {2} is the host name'] },
732+
{ key: 'manage.title.on', comment: ['{0} will be a user account name, {1} the provider name (e.g. Github), {2} is the tunnel name'] },
733733
'Remote Machine Access enabled for {0}({1}) as {2}', account.label, account.description, this.connectionInfo.hostName);
734734
items.push({ id: RemoteTunnelCommandIds.copyToClipboard, label: RemoteTunnelCommandLabels.copyToClipboard, description: this.connectionInfo.domain });
735735
} else {

0 commit comments

Comments
 (0)