Merge pull request microsoft#157635 from microsoft/tyriar/finalize_si_2

Tyriar · web-flow · commit 41d9c4965977 · 2022-08-09T09:14:05.000-07:00
Clarify 633 E sequence
diff --git a/src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts b/src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts
@@ -92,9 +92,10 @@ const enum VSCodeOscPt {
 	 * with parsing out the command, such as conpty not guaranteeing the position of the sequence or
 	 * the shell not guaranteeing that the entire command is even visible.
 	 *
-	 * The command line should escape ascii characters using the `\xAB` format, where AB are the
+	 * The command line can escape ascii characters using the `\xAB` format, where AB are the
 	 * hexadecimal representation of the character code (case insensitive), and escape the `\`
-	 * character using `\\`. This is particularly important for new line and semi-colon.
+	 * character using `\\`. It's required to escape semi-colon (`0x3b`) and characters 0x20 and
+	 * below, this is particularly important for new line and semi-colon.
 	 *
 	 * Some examples:
 	 *

Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,10 @@ const enum VSCodeOscPt {`
`92`	`92`	`* with parsing out the command, such as conpty not guaranteeing the position of the sequence or`
`93`	`93`	`* the shell not guaranteeing that the entire command is even visible.`
`94`	`94`	`*`
`95`		- * The command line should escape ascii characters using the `\xAB` format, where AB are the
	`95`	+ * The command line can escape ascii characters using the `\xAB` format, where AB are the
`96`	`96`	* hexadecimal representation of the character code (case insensitive), and escape the `\`
`97`		- * character using `\\`. This is particularly important for new line and semi-colon.
	`97`	+ * character using `\\`. It's required to escape semi-colon (`0x3b`) and characters 0x20 and
	`98`	`+ * below, this is particularly important for new line and semi-colon.`
`98`	`99`	`*`
`99`	`100`	`* Some examples:`
`100`	`101`	`*`