Fix startup performance (microsoft#210553)

Author: benibenj

src/vs/platform/actions/common/menuService.ts

@@ -443,13 +443,13 @@ function createMenuHide(menu: MenuId, command: ICommandAction | ISubmenuItem, st
 }
 
 export function createConfigureKeybindingAction(commandId: string, when: ContextKeyExpression | undefined = undefined, commandService: ICommandService, keybindingService: IKeybindingService): IAction {
-	const hasKeybinding = !!keybindingService.lookupKeybinding(commandId);
 	return toAction({
 		id: `configureKeybinding/${commandId}`,
-		label: hasKeybinding ? localize('change keybinding', "Change Keybinding") : localize('configure keybinding', "Configure Keybinding"),
+		label: localize('configure keybinding', "Configure Keybinding"),
 		run() {
 			// Only set the when clause when there is no keybinding
 			// It is possible that the action and the keybinding have different when clauses
+			const hasKeybinding = !!keybindingService.lookupKeybinding(commandId); // This may only be called inside the `run()` method as it can be expensive on startup. #210529
 			const whenValue = !hasKeybinding && when ? when.serialize() : undefined;
 			commandService.executeCommand('workbench.action.openGlobalKeybindings', `@command:${commandId}` + (whenValue ? ` +when:${whenValue}` : ''));
 		}

src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts

@@ -126,20 +126,17 @@ export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAcce
 		return [
 			...this.getCodeEditorCommandPicks(),
 			...this.getGlobalCommandPicks()
-		].map(picks => {
-			const hasKeybinding = !!this.keybindingService.lookupKeybindings(picks.commandId);
-			return {
-				...picks,
-				buttons: [{
-					iconClass: ThemeIcon.asClassName(Codicon.gear),
-					tooltip: hasKeybinding ? localize('change keybinding', "Change Keybinding") : localize('configure keybinding', "Configure Keybinding"),
-				}],
-				trigger: (): TriggerAction => {
-					this.preferencesService.openGlobalKeybindingSettings(false, { query: createKeybindingCommandQuery(picks.commandId, picks.commandWhen) });
-					return TriggerAction.CLOSE_PICKER;
-				},
-			};
-		});
+		].map(picks => ({
+			...picks,
+			buttons: [{
+				iconClass: ThemeIcon.asClassName(Codicon.gear),
+				tooltip: localize('configure keybinding', "Configure Keybinding"),
+			}],
+			trigger: (): TriggerAction => {
+				this.preferencesService.openGlobalKeybindingSettings(false, { query: createKeybindingCommandQuery(picks.commandId, picks.commandWhen) });
+				return TriggerAction.CLOSE_PICKER;
+			},
+		}));
 	}
 
 	protected hasAdditionalCommandPicks(filter: string, token: CancellationToken): boolean {