Skip to content

Commit 437379a

Browse files
author
aiday-mar
committed
Removing unecessary if check
1 parent fd2b1ef commit 437379a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,8 @@ export class StickyLineCandidateProvider extends Disposable {
9393

9494
private findSumOfRangesOfGroup(outline: OutlineGroup | OutlineElement): number {
9595
let res = 0;
96-
if (outline.children.size !== 0) {
97-
for (const child of outline.children.values()) {
98-
res += this.findSumOfRangesOfGroup(child);
99-
}
96+
for (const child of outline.children.values()) {
97+
res += this.findSumOfRangesOfGroup(child);
10098
}
10199
if (outline instanceof OutlineElement) {
102100
return res + outline.symbol.range.endLineNumber - outline.symbol.selectionRange.startLineNumber;
@@ -110,16 +108,18 @@ export class StickyLineCandidateProvider extends Disposable {
110108
const model = this._editor.getModel();
111109
const modelVersionId = model.getVersionId();
112110
let outlineModel = await OutlineModel.create(this._languageFeaturesService.documentSymbolProvider, model, token) as OutlineModel;
111+
112+
// When several possible outline providers
113113
if (outlineModel.children.size !== 0 && outlineModel.children.values().next().value instanceof OutlineGroup) {
114114
if (outlineModel.children.has(this._providerString)) {
115115
outlineModel = outlineModel.children.get(this._providerString) as unknown as OutlineModel;
116116
} else {
117117
let providerString = '';
118-
let maxTotalSumRanges = 0;
118+
let maxTotalSumOfRanges = 0;
119119
for (const [key, outlineGroup] of outlineModel.children.entries()) {
120120
const totalSumRanges = this.findSumOfRangesOfGroup(outlineGroup);
121-
if (totalSumRanges > maxTotalSumRanges) {
122-
maxTotalSumRanges = totalSumRanges;
121+
if (totalSumRanges > maxTotalSumOfRanges) {
122+
maxTotalSumOfRanges = totalSumRanges;
123123
providerString = key;
124124
}
125125
}

0 commit comments

Comments
 (0)