Adopt prefer-readonly in JS/TS extension (microsoft#165089)

Author: mjbvz

.eslintignore

@@ -13,6 +13,8 @@
 **/extensions/notebook-renderers/renderer-out/index.js
 **/extensions/simple-browser/media/index.js
 **/extensions/typescript-language-features/test-workspace/**
+**/extensions/typescript-language-features/extension.webpack.config.js
+**/extensions/typescript-language-features/extension-browser.webpack.config.js
 **/extensions/vscode-api-tests/testWorkspace/**
 **/extensions/vscode-api-tests/testWorkspace2/**
 **/fixtures/**

extensions/typescript-language-features/.eslintrc.js

@@ -0,0 +1,10 @@
+module.exports = {
+	"parserOptions": {
+		"tsconfigRootDir": __dirname,
+		"project": "./tsconfig.json"
+	},
+	"rules": {
+		"@typescript-eslint/prefer-optional-chain": "warn",
+		"@typescript-eslint/prefer-readonly": "warn"
+	}
+};

extensions/typescript-language-features/.eslintrc.json

@@ -16,10 +16,11 @@ export interface IExperimentationTelemetryReporter extends tas.IExperimentationT
  * but will only do so when passed to an {@link ExperimentationService}.
  */
 
-export class ExperimentationTelemetryReporter
-	implements IExperimentationTelemetryReporter {
+export class ExperimentationTelemetryReporter implements IExperimentationTelemetryReporter {
+
 	private _sharedProperties: Record<string, string> = {};
-	private _reporter: VsCodeTelemetryReporter;
+	private readonly _reporter: VsCodeTelemetryReporter;
+
 	constructor(reporter: VsCodeTelemetryReporter) {
 		this._reporter = reporter;
 	}

extensions/typescript-language-features/src/experimentTelemetryReporter.ts

@@ -13,8 +13,8 @@ interface ExperimentTypes {
 }
 
 export class ExperimentationService {
-	private _experimentationServicePromise: Promise<tas.IExperimentationService>;
-	private _telemetryReporter: IExperimentationTelemetryReporter;
+	private readonly _experimentationServicePromise: Promise<tas.IExperimentationService>;
+	private readonly _telemetryReporter: IExperimentationTelemetryReporter;
 
 	constructor(telemetryReporter: IExperimentationTelemetryReporter, id: string, version: string, globalState: vscode.Memento) {
 		this._telemetryReporter = telemetryReporter;

extensions/typescript-language-features/src/experimentationService.ts

@@ -36,7 +36,7 @@ export abstract class TypeScriptBaseCodeLensProvider implements vscode.CodeLensP
 
 	public constructor(
 		protected client: ITypeScriptServiceClient,
-		private cachedResponse: CachedResponse<Proto.NavTreeResponse>
+		private readonly cachedResponse: CachedResponse<Proto.NavTreeResponse>
 	) { }
 
 

extensions/typescript-language-features/src/languageFeatures/codeLens/baseCodeLensProvider.ts

@@ -37,7 +37,7 @@ class TypeScriptDocumentSymbolProvider implements vscode.DocumentSymbolProvider
 
 	public constructor(
 		private readonly client: ITypeScriptServiceClient,
-		private cachedResponse: CachedResponse<Proto.NavTreeResponse>,
+		private readonly cachedResponse: CachedResponse<Proto.NavTreeResponse>,
 	) { }
 
 	public async provideDocumentSymbols(document: vscode.TextDocument, token: vscode.CancellationToken): Promise<vscode.DocumentSymbol[] | undefined> {

extensions/typescript-language-features/src/languageFeatures/documentSymbol.ts

@@ -185,7 +185,7 @@ class SourceAddMissingImports extends SourceAction {
 
 class TypeScriptAutoFixProvider implements vscode.CodeActionProvider {
 
-	private static kindProviders = [
+	private static readonly kindProviders = [
 		SourceFixAll,
 		SourceRemoveUnused,
 		SourceAddMissingImports,

extensions/typescript-language-features/src/languageFeatures/fixAll.ts

@@ -1,3 +1,7 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 import * as ts from 'typescript/lib/tsserverlibrary';
 export = ts.server.protocol;
 

extensions/typescript-language-features/src/protocol.d.ts

@@ -34,9 +34,9 @@ export class WorkerServerProcess implements TsServerProcess {
 		]);
 	}
 
-	private _onDataHandlers = new Set<(data: Proto.Response) => void>();
-	private _onErrorHandlers = new Set<(err: Error) => void>();
-	private _onExitHandlers = new Set<(code: number | null, signal: string | null) => void>();
+	private readonly _onDataHandlers = new Set<(data: Proto.Response) => void>();
+	private readonly _onErrorHandlers = new Set<(err: Error) => void>();
+	private readonly _onExitHandlers = new Set<(code: number | null, signal: string | null) => void>();
 
 	public constructor(
 		private readonly worker: Worker,