Add action label and keybindings for the editor hover status bar in the editor hover accessible view/help (microsoft#218269)

adding label and keybindings into the editor hover accessibility view and help

Author: aiday-mar

src/vs/base/browser/ui/hover/hoverWidget.ts

@@ -50,12 +50,18 @@ export class HoverAction extends Disposable {
 		return new HoverAction(parent, actionOptions, keybindingLabel);
 	}
 
+	public readonly actionLabel: string;
+	public readonly actionKeybindingLabel: string | null;
+
 	private readonly actionContainer: HTMLElement;
 	private readonly action: HTMLElement;
 
 	private constructor(parent: HTMLElement, actionOptions: { label: string; iconClass?: string; run: (target: HTMLElement) => void; commandId: string }, keybindingLabel: string | null) {
 		super();
 
+		this.actionLabel = actionOptions.label;
+		this.actionKeybindingLabel = keybindingLabel;
+
 		this.actionContainer = dom.append(parent, $('div.action-container'));
 		this.actionContainer.setAttribute('tabindex', '0');
 

src/vs/editor/contrib/hover/browser/contentHoverRendered.ts

@@ -21,6 +21,7 @@ import { ColorHoverParticipant } from 'vs/editor/contrib/colorPicker/browser/col
 import { localize } from 'vs/nls';
 import { InlayHintsHover } from 'vs/editor/contrib/inlayHints/browser/inlayHintsHover';
 import { BugIndicatingError } from 'vs/base/common/errors';
+import { HoverAction } from 'vs/base/browser/ui/hover/hoverWidget';
 
 export class RenderedContentHover extends Disposable {
 
@@ -175,6 +176,10 @@ interface IRenderedContentStatusBar {
 	 * The HTML element containing the hover status bar.
 	 */
 	hoverElement: HTMLElement;
+	/**
+	 * The actions of the hover status bar.
+	 */
+	actions: HoverAction[];
 }
 
 type IRenderedContentHoverPartOrStatusBar = IRenderedContentHoverPart | IRenderedContentStatusBar;
@@ -189,6 +194,10 @@ class RenderedStatusBar implements IDisposable {
 		return this._statusBar.hoverElement;
 	}
 
+	get actions(): HoverAction[] {
+		return this._statusBar.actions;
+	}
+
 	dispose() {
 		this._statusBar.dispose();
 	}
@@ -270,6 +279,7 @@ class RenderedContentHoverParts extends Disposable {
 			this._renderedParts.push({
 				type: 'statusBar',
 				hoverElement: renderedStatusBar.hoverElement,
+				actions: renderedStatusBar.actions,
 			});
 		}
 		return toDisposable(() => { disposables.dispose(); });
@@ -332,7 +342,16 @@ class RenderedContentHoverParts extends Disposable {
 			return '';
 		}
 		if (renderedPart.type === 'statusBar') {
-			return localize('hoverAccessibilityStatusBar', "This is a hover status bar.");
+			const statusBarDescription = [localize('hoverAccessibilityStatusBar', "This is a hover status bar.")];
+			for (const action of renderedPart.actions) {
+				const keybinding = action.actionKeybindingLabel;
+				if (keybinding) {
+					statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithKeybinding', "It has an action with label {0} and keybinding {1}.", action.actionLabel, keybinding));
+				} else {
+					statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithoutKeybinding', "It has an action with label {0}.", action.actionLabel));
+				}
+			}
+			return statusBarDescription.join('\n');
 		}
 		return renderedPart.participant.getAccessibleContent(renderedPart.hoverPart);
 	}

src/vs/editor/contrib/hover/browser/contentHoverStatusBar.ts

@@ -13,6 +13,8 @@ const $ = dom.$;
 export class EditorHoverStatusBar extends Disposable implements IEditorHoverStatusBar {
 
 	public readonly hoverElement: HTMLElement;
+	public readonly actions: HoverAction[] = [];
+
 	private readonly actionsElement: HTMLElement;
 	private _hasContent: boolean = false;
 
@@ -39,7 +41,9 @@ export class EditorHoverStatusBar extends Disposable implements IEditorHoverStat
 		const keybinding = this._keybindingService.lookupKeybinding(actionOptions.commandId);
 		const keybindingLabel = keybinding ? keybinding.getLabel() : null;
 		this._hasContent = true;
-		return this._register(HoverAction.render(this.actionsElement, actionOptions, keybindingLabel));
+		const action = this._register(HoverAction.render(this.actionsElement, actionOptions, keybindingLabel));
+		this.actions.push(action);
+		return action;
 	}
 
 	public append(element: HTMLElement): HTMLElement {